Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note styling #20

Closed
jeff-h opened this issue Aug 12, 2017 · 10 comments
Closed

Note styling #20

jeff-h opened this issue Aug 12, 2017 · 10 comments

Comments

@jeff-h
Copy link
Contributor

jeff-h commented Aug 12, 2017

I'm wondering what your (longer-term) plans are regarding note text styling.

My hope is you'd consider offering basic style formatting, depending on the chosen file type eg RTF would offer: Bold, Italics, Strikethrough and underline, and Markdown would add H1 to H6. Neither would offer font face or size changes.

@jeffgeorge
Copy link

Thanks for adding this initial functionality!

To improve feature parity with NV / NVAlt, are there possible considerations to move the pin/unpin key shortcut from ⌘+Y to something else, and move Strikethrough to ⌘+Y?

Maybe move pin/unpin to ⌘+P, since ⌘+P presently crashes FSNotes? (Unless FSNotes plans on implementing Printing, I guess?)

@mikepqr
Copy link

mikepqr commented Aug 22, 2017

+1 for moving ⌘+Y to strikethrough.

Please don't use ⌘+P for anything other than print (which FSNotes should implement). There's a widespread OS-wide expectation about what that shortcut does that should not be ignored.

@jeff-h
Copy link
Contributor Author

jeff-h commented Aug 23, 2017

Even though as far as I know ⌘+Y is fairly unique to nvALT... I'd also love ⌘+Y for strikethrough. It's really handy in my particular useage of nvALT.

The pin idea is really neat — I wonder what other keyboard shortcut would make sense for it?

@glushchenko
Copy link
Owner

glushchenko commented Aug 25, 2017

Hi guys, thank for proposals and feedback. Pin now triggered on cmd - *

Checkout new build https://github.com/glushchenko/fsnotes/releases/download/0.16/FSNotes.app.zip

@jeffgeorge
Copy link

Thanks for updating this @glushchenko, but I'm having some issues with the RTF implementation. Instead of acting as a Toggle, the new commands just apply a setting, which means in RTF mode you can't un-style text.

Formatting also doesn't seem to be additive anymore. I'm having trouble testing this thoroughly, but in RTF mode once I have something bold, if I ⌘+U to underline it, it underlines but the bold drops. If I try to re-bold it, with ⌘+B nothing happens. If I have underlined text and then try to Italicize it with ⌘+I that works. Selecting it again and trying to ⌘+B to bold the text does nothing. ⌘+U to re-underline it drops the italicization. Still no way to clear formatting altogether.

Obviously this isn't an issue in Markdown mode because it's all plaintext.

@glushchenko
Copy link
Owner

@jeffgeorge, will be fixed in next release.

@glushchenko
Copy link
Owner

@jeffgeorge fixed, 0.16 updated.

@jeff-h
Copy link
Contributor Author

jeff-h commented Aug 29, 2017

This is really awesome work.

I noticed one oddity — setting a style on a selected piece of text should leave the selected text still selected but it currently deselects it.

glushchenko added a commit that referenced this issue Aug 29, 2017
@thiemehennis
Copy link

What about strikethrough? It's greyed out in my installation. Will it be implemented in the future? I could not find a definitive answer in this thread so I decided to reopen it. I use md to save my files.

@jeff-h
Copy link
Contributor Author

jeff-h commented Aug 1, 2018

Partially related; strikethrough works fine in rtf (I don't use md).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants