Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Renaming and Deleting Notes #24

Closed
proksch opened this issue Aug 15, 2017 · 6 comments
Closed

Feature Request: Renaming and Deleting Notes #24

proksch opened this issue Aug 15, 2017 · 6 comments

Comments

@proksch
Copy link

proksch commented Aug 15, 2017

I really like how the app is starting to shape up! I think it would be very useful to have the means to rename a file (= note title) and to delete it, e.g., by adding a context menu to the list of notes. I realized that the renaming already works sometimes by clicking on an item, but not always... and this functionality seems to stop working after the app runs for some time.

@glushchenko
Copy link
Owner

You can select note and press “cmd-r” for rename, or “cmd-delete” for remove.

@jeff-h
Copy link
Contributor

jeff-h commented Aug 16, 2017

There do seem to be a few scenarios where the shortcuts don't work. For example, I suspect that when the EditTextView is first responder, the key shortcuts never go into the keyDown func in NotesTableView (and vice-versa).

Could the keyDown's of NotesTableView and EditTextView be merged into one method on the ViewController?

@glushchenko
Copy link
Owner

Now (cmd-r/delete) shortcuts works in edit text view too:
https://github.com/glushchenko/fsnotes/releases/download/0.12/FSNotes.app.zip

@jeff-h
Copy link
Contributor

jeff-h commented Aug 16, 2017

Excellent!

glushchenko added a commit that referenced this issue Aug 16, 2017
@jeff-h
Copy link
Contributor

jeff-h commented Aug 17, 2017

Nice consolidation of all that keyboard event code! I had a quick try but couldn't get all the events to flow through the ViewController — I was missing your calls to NSEvent.addLocalMonitorForEvents.

@glushchenko
Copy link
Owner

glushchenko commented Aug 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants