Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace CI credentials with gluwa-bot account #1680

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Replace CI credentials with gluwa-bot account #1680

merged 1 commit into from
Aug 12, 2024

Conversation

atodorov
Copy link
Contributor

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov atodorov merged commit 39d399a into testnet Aug 12, 2024
14 of 48 checks passed
@atodorov atodorov deleted the update-ci-for-testnet branch August 12, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DylanVerstraete DylanVerstraete DylanVerstraete approved these changes

@beqaabu beqaabu beqaabu approved these changes

@BradleyOlson64 BradleyOlson64 Awaiting requested review from BradleyOlson64

@rustlang-dev rustlang-dev Awaiting requested review from rustlang-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atodorov @DylanVerstraete @beqaabu