Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge testnet into main #1686

Merged
merged 937 commits into from
Aug 13, 2024
Merged

Merge testnet into main #1686

merged 937 commits into from
Aug 13, 2024

Conversation

beqaabu
Copy link
Contributor

@beqaabu beqaabu commented Aug 13, 2024

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

dependabot bot and others added 30 commits December 4, 2023 22:16
@dependabot @atodorov
build(deps-dev): bump typescript in /integration-tests
964cee4 
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.2.2 to 5.3.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v5.2.2...v5.3.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @atodorov
build(deps-dev): bump @typescript-eslint/parser in /scripts/cc-cli
e32152c 
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 6.9.1 to 6.13.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.13.1/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @atodorov
build(deps-dev): bump typescript from 5.2.2 to 5.3.2 in /scripts/cc-cli
9d5e851 
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.2.2 to 5.3.2.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v5.2.2...v5.3.2)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @atodorov
build(deps-dev): bump eslint from 8.53.0 to 8.54.0 in /creditcoin-js
64e04b0 
Bumps [eslint](https://github.com/eslint/eslint) from 8.53.0 to 8.54.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.53.0...v8.54.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @atodorov
build(deps-dev): bump @typescript-eslint/parser in /scripts/js
a38686b 
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 6.9.1 to 6.13.2.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.13.2/packages/parser)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @atodorov
build(deps-dev): bump prettier from 3.0.0 to 3.1.0 in /scripts/js
b1478f6 
Bumps [prettier](https://github.com/prettier/prettier) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.0.0...3.1.0)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @atodorov
build(deps-dev): bump prettier from 3.0.0 to 3.1.0 in /integration-tests
5f7596f 
Bumps [prettier](https://github.com/prettier/prettier) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.0.0...3.1.0)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @atodorov
build(deps-dev): bump prettier from 3.0.3 to 3.1.0 in /creditcoin-js
59429f7 
Bumps [prettier](https://github.com/prettier/prettier) from 3.0.3 to 3.1.0.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.0.3...3.1.0)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @atodorov
build(deps-dev): bump eslint from 8.54.0 to 8.55.0 in /creditcoin-js
d06e5ac 
Bumps [eslint](https://github.com/eslint/eslint) from 8.54.0 to 8.55.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.54.0...v8.55.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @atodorov
build(deps): bump bstr from 1.6.2 to 1.8.0
ea9d15e 
Bumps [bstr](https://github.com/BurntSushi/bstr) from 1.6.2 to 1.8.0.
- [Commits](BurntSushi/bstr@1.6.2...1.8.0)

---
updated-dependencies:
- dependency-name: bstr
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @atodorov
build(deps-dev): bump prettier from 3.0.1 to 3.1.0 in /scripts/cc-cli
6c4a129 
Bumps [prettier](https://github.com/prettier/prettier) from 3.0.1 to 3.1.0.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.0.1...3.1.0)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@atodorov
Reformat with newer version of prettier
111f592
@atodorov
updated command in integration test readme to work with new bags list…
314c1cc 
… binary
@atodorov
burn and burn_all integration test
ee92efc
@atodorov
fixed failing burn test
83e3ee7
@atodorov
Remove obsolete --mining-key command line argument
0486492
@atodorov
Do not use sudoSigner.address in tests to avoid confusion
4141072 
for burn()/burnAll() the last parameter, `collector`, is who can collect
on the Creditcoin3 side whose value doesn't really matter as part of the
integration test suite on the Creditcoin 2 side.

Replace with the address of the wallet signing the transactions to avoid
confusion over the use of variable called `sudoSigner`. In this scenario
we're assuming the same address exists both on CC2 and CC3!
@atodorov
Add unit tests for burn_all() extrinsic
8f3c90f
@atodorov
Add unit tests for burn() extrinsic
ea2799b
@atodorov
Add test for creditcoin-cli inside the container
d2322a2
@atodorov
Add missing dependency chalk
3a1bf6e 
introduced in ed7a11b
@atodorov @nathanwhit
Add test for creditcoin-cli inside the container
9f7e039
@atodorov @nathanwhit
Add missing dependency chalk
975704f 
introduced in ed7a11b
@atodorov @nathanwhit
Forcefully remove test container in CI job
1f14af8 
because we now use the same container name when launching via the
`docker` command and via `docker-compose` we need to make sure the
container is no more before proceeding to the next step of the test.

Sometimes killing the process may take a bit longer and docker falls on
its face when that happens!
@atodorov @nathanwhit
When testing against a disconnected node use the credentials for Testnet
f0cfdfc 
instead of //Alice. ALICE & BOB don't have any funds on Testnet anymore!

Also see 1d0f238
@nathanwhit
Auto-update creditcoin-js type definitions
05f398a
@atodorov @nathanwhit
Bump version to 2.232.1
da32032
@atodorov @nathanwhit
Testnet & Devnet have switched to Sepolia
dc67b19 
WARNING: There are two contracts on Sepolia for each token (G-CRE &
GATE). Devnet & Testnet use the same GCRE contract however it has been
deployed twice and offchain workers for each network are configured
differently!

- ETHEREUM_NODE_URL in 1Password has been updated
- TESTNET_ETHEREUM_NODE_URL secret in GitHub has been updated
@dependabot @atodorov
build(deps): bump futures-lite from 2.0.1 to 2.1.0
4cf85ca 
Bumps [futures-lite](https://github.com/smol-rs/futures-lite) from 2.0.1 to 2.1.0.
- [Release notes](https://github.com/smol-rs/futures-lite/releases)
- [Changelog](https://github.com/smol-rs/futures-lite/blob/master/CHANGELOG.md)
- [Commits](smol-rs/futures-lite@v2.0.1...v2.1.0)

---
updated-dependencies:
- dependency-name: futures-lite
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @atodorov
build(deps): bump thiserror from 1.0.50 to 1.0.53
aa5f98e 
Bumps [thiserror](https://github.com/dtolnay/thiserror) from 1.0.50 to 1.0.53.
- [Release notes](https://github.com/dtolnay/thiserror/releases)
- [Commits](dtolnay/thiserror@1.0.50...1.0.53)

---
updated-dependencies:
- dependency-name: thiserror
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
beqaabu and others added 20 commits August 9, 2024 12:51
@beqaabu
chore: more lints
fd1caa1
@beqaabu
chore: fix migration benchmarks
dc14251
@beqaabu
chore: more js
2929ddd
@beqaabu
chore: pr comments
8cbae96
@beqaabu
chore: try to fix ci
4ce6562
@beqaabu
chore: revert to old toolchain version
da137ac
@beqaabu
feat: remove setting gate contract and update js client
e72d187
@beqaabu
Auto-update creditcoin-js type definitions
98ad675
@beqaabu
chore: update readme
1fd01a6
@atodorov
Replace CI credentials with gluwa-bot account
39d399a
@beqaabu
merge dev into testnet
d914cea
@beqaabu
chore: fix js lints after merge
2628ca1
@beqaabu
chore: remove collectCoins tests from cli
b613687
Auto-update pallet weights
3679419
@beqaabu
chore: updated lender seed to match sudo for runtime upgrade test
6e6e23c
Auto-update pallet weights
4f88793
@atodorov
Merge pull request #1684 from gluwa/merge-dev-into-testnet
d8c4376 
Merge dev into testnet
@beqaabu
feat: merge testnet into main
a269de5
@beqaabu
chore: fix errors after merge
d4796ef
@beqaabu
chore: remove gate contract tests
7d0d1b3
@beqaabu beqaabu requested review from atodorov, dlebee and dave1374 and removed request for atodorov August 13, 2024 13:21
@dlebee dlebee merged commit 44a4f89 into main Aug 13, 2024
38 of 42 checks passed
@dlebee dlebee deleted the merge-testnet-into-main branch August 13, 2024 19:44
@dlebee dlebee restored the merge-testnet-into-main branch August 13, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlebee dlebee dlebee approved these changes

@atodorov atodorov atodorov approved these changes

@dave1374 dave1374 Awaiting requested review from dave1374

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@beqaabu @atodorov @dlebee @zacharyfrederick @frankli-dev @pLabarta @BradleyOlson64