New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow git tags with suffix -devnet #1689

Merged

beqaabu merged 1 commit into dev from allow_devnet_releases

Aug 14, 2024

Contributor

atodorov commented Aug 14, 2024

Description of proposed changes

Practical tips for PR review & merge:

All GitHub Actions report PASS
Newly added code/functions have unit tests
- Coverage tools report all newly added lines as covered
- The positive scenario is exercised
- Negative scenarios are exercised, e.g. assert on all possible errors
- Assert on events triggered if applicable
- Assert on changes made to storage if applicable
Modified behavior/functions - try to make sure above test items are covered
Integration tests are added if applicable/needed


          Allow git tags with suffix -devnet

cd01000

atodorov requested a review from beqaabu

August 14, 2024 09:34

beqaabu approved these changes

View reviewed changes

beqaabu merged commit ddcbef6 into dev

24 of 34 checks passed

beqaabu deleted the allow_devnet_releases branch

August 14, 2024 09:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet