Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] integrate interlude player with spotify controls #44

Closed
marekjedrzejewski opened this issue May 6, 2015 · 10 comments
Closed

Comments

@marekjedrzejewski
Copy link

First of all, thanks for amazing piece of software, doing really great job unlike most ad muting scripts out there :)
I have one suggestion though, that would make it GODLIKE for me:
If I want the whole song to play through rather than autoresuming I HAVE TO listen to whole track. If I click next on spotify track changes, but it is still paused, and interlude player track goes on.
If interlude player would stop and let spotify play the track that would be perfect :)
I hope that's not something impossible,
Keep up the good work :)

@gmdfalk
Copy link
Owner

gmdfalk commented May 6, 2015

Hey,

i'd love to help you but i don't understand what you're saying.
Can you elaborate on this?
If I click next on spotify track changes, but it is still paused, and interlude player track goes on.

I'll be back in around an hour.

@marekjedrzejewski
Copy link
Author

  1. I have spotify and blockify runing.
  2. There's ad playing.
  3. Blockify mutes ad and plays track from playlist.
  4. Ad in Spotify ends.
  5. I click next.
  6. Spotify track is changed, but paused on beginning. (and the blockify track goes on)
  7. Blockify track ends.
  8. Spotify track starts.

How I'd love it to be:
5. I click next.
6. Spotify track changes and is playing, and blockify track stops.

Hope it's clearer now :)

gmdfalk pushed a commit that referenced this issue May 6, 2015
@marekjedrzejewski
Copy link
Author

Wow, that was fast :)
Great job, but not quite what I meant :( But you're no mindreader, and I didn't stated it clearly enough.
I thought about changing track inside spotify client, and blockify catching this change.
It's about making blockify as invisible as can be while maintaining its functions.
Sorry for trouble ;)

@gmdfalk
Copy link
Owner

gmdfalk commented May 7, 2015

Should be doable. I'll look into it soon.

@gmdfalk
Copy link
Owner

gmdfalk commented May 8, 2015

Turns out i can't do that as I only know if the song has changed not what prompted the change i.e. i don't know whether you just clicked next or a song simply ended.

What you could do to achieve the desired effect is bind the blockify actions to keys, i.e. to play the next song bind pkill -RTMIN+1 -f "python2.*blockify" to a key.
For the previous song it's pkill -RTMIN -f "python2.*blockify".
Toggle autoresume would be pkill -RTMIN+13 -f "python2.*blockify".

For more actions, see the Controls/Actions section in https://github.com/mikar/blockify/blob/master/README.md.

@gmdfalk gmdfalk closed this as completed May 8, 2015
@marekjedrzejewski
Copy link
Author

Turns out i can't do that as I only know if the song has changed not what prompted the change i.e. i don't know whether you just clicked next or a song simply ended.

But if song has changed and is not on blocked list I don't see why shouldn't it work. I mean, maybe someone is playing both blockify and spotify player, but that would be pretty weird.
Song doesn't change on its own if it's paused, so that shouldn't be a problem (well, first song after ads shouldn't trigger it, but that's all). Or maybe I'm missing something?

@gmdfalk
Copy link
Owner

gmdfalk commented May 8, 2015

It would just be normal autoresume behaviour. If a song ends and the next song is not an ad, resume spotify playback.

@marekjedrzejewski
Copy link
Author

Yep, but that would work for the song after that ;)

gmdfalk pushed a commit that referenced this issue May 8, 2015
@marekjedrzejewski
Copy link
Author

Works, but partially. When blockify song is skipped it pauses, on next ad it behaves like it was before the fix. On next song it can be skipped again
Probably changing song to next one instead of just pausing it would fix it completely

@gmdfalk
Copy link
Owner

gmdfalk commented May 10, 2015

I mean, maybe someone is playing both blockify and spotify player, but that would be pretty weird.
That's precisely what happens when a commercial is playing and interlude music is enabled.
Song doesn't change on its own if it's paused.
It does when the interlude song finishes.

I took another stab at this but it comes down to the fact that i don't know why a track changed.

As I said when closing this issue though you can get the desired effect if you either
a) use next/previous functions provided by blockify-ui, either via the buttons or signals
b) toggle autoresume on-demand using the signal or the checkbox provided by blockify-ui

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants