Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

Support 1.20.6 #129

Merged
merged 1 commit into from
May 29, 2024
Merged

Support 1.20.6 #129

merged 1 commit into from
May 29, 2024

Conversation

datatags
Copy link
Contributor

Info

This PR fixes support for 1.20.6.

Details

Previously, attempting to use MobChip on 1.20.6 would result in an error message like this:

[12:48:48 ERROR]: Could not pass event InventoryClickEvent to [...]
java.lang.AssertionError: Invalid Version: 1.20.6
        at [...].mobchip.abstraction.ChipUtil.bukkitToCraftBukkit(ChipUtil.java:194)

Since 1.20.5 and 1.20.6 are nearly identical under the hood, simply adding a "1.20.6" case to the switch statement adds support for it.

Tested Environments

OS

OS: Debian 12

Java / Minecraft

MC Builds

  • Tested on Latest Spigot Version
  • Tested on Latest Paper / Purpur Version

JDK Builds

Tested on:

  • JDK Version 8/11
  • JDK Version 17/18
  • JDK Version 21

Copy link
Owner

@gmitch215 gmitch215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Catch.

@gmitch215 gmitch215 merged commit c441b0c into gmitch215:master May 29, 2024
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants