-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DoubleLoopOptimization: reduce runtime for CI #138
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportBase: 93.29% // Head: 93.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
========================================
Coverage 93.29% 93.30%
========================================
Files 54 57 +3
Lines 5877 6105 +228
========================================
+ Hits 5483 5696 +213
- Misses 394 409 +15 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in this PR can be approved as-is. Note (mostly to self): additional steps are needed to ensure these changes take effect in CI:
- Add env var to CI job environment
- Remove notebook cell tag that causes the cell that would be affected by the reduced runtime to be skipped
- Enable RE DoubleLoopOptimization to run on Linux (Fix issues due to capitalization sample-data#1)
Addresses issue:
#127
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: