Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoubleLoopOptimization: reduce runtime for CI #138

Merged
merged 5 commits into from
Oct 3, 2022

Conversation

dguittet
Copy link
Contributor

Addresses issue:

#127

Summary/Motivation:

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Aug 15, 2022
Copy link
Contributor

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Base: 93.29% // Head: 93.30% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (cf66c7e) compared to base (31cd536).
Patch has no changes to coverable lines.

❗ Current head cf66c7e differs from pull request most recent head dac40f7. Consider uploading reports for the commit dac40f7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #138    +/-   ##
========================================
  Coverage   93.29%   93.30%            
========================================
  Files          54       57     +3     
  Lines        5877     6105   +228     
========================================
+ Hits         5483     5696   +213     
- Misses        394      409    +15     
Impacted Files Coverage Δ
dispatches/unit_models/tests/test_wind_power.py
...s/case_studies/renewables_case/wind_battery_LMP.py
...udies/nuclear_case/tests/test_nuclear_flowsheet.py
dispatches/properties/h2_ideal_vap.py
dispatches/unit_models/wind_power.py
dispatches/properties/hturbine_ideal_vap.py
...ischarge_design_ultra_supercritical_power_plant.py
...lant/storage/multiperiod_integrated_storage_usc.py
dispatches/properties/thermaloil_properties.py
...se_studies/renewables_case/wind_battery_PEM_LMP.py
... and 85 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ksbeattie ksbeattie enabled auto-merge (squash) September 19, 2022 17:13
Copy link
Contributor

@lbianchi-lbl lbianchi-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR can be approved as-is. Note (mostly to self): additional steps are needed to ensure these changes take effect in CI:

  • Add env var to CI job environment
  • Remove notebook cell tag that causes the cell that would be affected by the reduced runtime to be skipped
  • Enable RE DoubleLoopOptimization to run on Linux (Fix issues due to capitalization sample-data#1)

@ksbeattie ksbeattie merged commit 1745d9f into gmlc-dispatches:main Oct 3, 2022
@dguittet dguittet deleted the RE-ci branch March 31, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants