Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated gdpopt solver call #141

Merged
merged 4 commits into from
Sep 13, 2022

Conversation

nareshsusarla
Copy link
Contributor

Addresses issue:

Updates GDPopt solver call to address latest changes to pyomo GDPopt

Summary/Motivation:

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #141 (41e2c0d) into main (81847cb) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   93.32%   93.29%   -0.04%     
==========================================
  Files          54       54              
  Lines        5904     5877      -27     
==========================================
- Hits         5510     5483      -27     
  Misses        394      394              
Impacted Files Coverage Δ
...e/charge_design_ultra_supercritical_power_plant.py 96.53% <100.00%> (-0.04%) ⬇️
...ischarge_design_ultra_supercritical_power_plant.py 95.35% <100.00%> (-0.09%) ⬇️
..._plant/storage/tests/test_charge_usc_powerplant.py 100.00% <100.00%> (ø)
...ant/storage/tests/test_discharge_usc_powerplant.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Aug 29, 2022
@lbianchi-lbl
Copy link
Contributor

@nareshsusarla @esrawli Is this the test that's currently causing the long runtimes?

https://github.com/gmlc-dispatches/dispatches/blob/main/dispatches/case_studies/fossil_case/ultra_supercritical_plant/storage/tests/test_discharge_usc_powerplant.py#L106-L108

If so, you can do this so that it's skipped:

@pytest.skip(reason="Temporary skip after significant runtime increase with Pyomo 6.4.2")
@pytest.mark.integration
def test_usc_discharge_model(model):
    # Add missing functions to complete the discharge model (add bounds
    # and disjunctions)
    discharge_usc.add_bounds(model, power_max=power_max)
    discharge_usc.disconnect_arcs(model)
    discharge_usc.add_disjunction(model)

@nareshsusarla nareshsusarla marked this pull request as ready for review September 13, 2022 20:29
@esrawli
Copy link
Contributor

esrawli commented Sep 13, 2022

We added a maximum number of iterations to the NLP solver in GDPopt to reduce the runtime of discharge test instead of skipping the function that was causing the long runtime

@lbianchi-lbl lbianchi-lbl enabled auto-merge (squash) September 13, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants