Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RE Notebook Check #181

Closed
wants to merge 9 commits into from
Closed

Fix RE Notebook Check #181

wants to merge 9 commits into from

Conversation

dguittet
Copy link
Contributor

Addresses issue:

#176

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@dguittet
Copy link
Contributor Author

@ksbeattie @lbianchi-lbl There are failing tests still but the notebook completes in time

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Mar 20, 2023
@lbianchi-lbl
Copy link
Contributor

lbianchi-lbl commented Mar 20, 2023

For reference, these seem to be the relevant updates to the source code cells:

image

lbianchi-lbl
lbianchi-lbl previously approved these changes Mar 20, 2023
ksbeattie
ksbeattie previously approved these changes Mar 27, 2023
Copy link
Contributor

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@dguittet dguittet dismissed stale reviews from ksbeattie and lbianchi-lbl via b1c59c7 March 27, 2023 17:24
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3cad6e1) 93.74% compared to head (006633e) 93.74%.

❗ Current head 006633e differs from pull request most recent head ec37b24. Consider uploading reports for the commit ec37b24 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   93.74%   93.74%           
=======================================
  Files          59       59           
  Lines        7130     7130           
=======================================
  Hits         6684     6684           
  Misses        446      446           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

lbianchi-lbl added a commit to lbianchi-lbl/dispatches that referenced this pull request Mar 29, 2023
@lbianchi-lbl
Copy link
Contributor

Closing this in favor of #190 which is on a non-main branch.

lbianchi-lbl added a commit that referenced this pull request Mar 29, 2023
* Apply changes to DoubleLoopOptimization.ipynb from #181

* Display durations for notebooks exec checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants