Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rts_gmlc data package for Double Loop #183

Merged
merged 3 commits into from
May 24, 2023

Conversation

lbianchi-lbl
Copy link
Contributor

Summary/Motivation:

  • Switch to using the rts_gmlc data package through data_packages.api to access RTS-GMLC data for Double Loop simulations for consistency with the other data packages.

Changes proposed in this PR:

  • Add dispatches-data-packages as a requirement
  • Add dispatches-rts-gmlc-data (providing the rts_gmlc data package) as a requirement
  • Make the necessary changes in DL notebooks and script for all 3 case studies

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbianchi-lbl lbianchi-lbl added the Priority:Normal Medium Priority Issue or PR label Mar 20, 2023
@lbianchi-lbl lbianchi-lbl self-assigned this Mar 20, 2023
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (08c117a) 89.49% compared to head (2cbb425) 89.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   89.49%   89.49%           
=======================================
  Files          67       67           
  Lines        8238     8238           
=======================================
  Hits         7373     7373           
  Misses        865      865           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -32,7 +32,7 @@
from pyomo.common.fileutils import this_file_dir
import pandas as pd
from pathlib import Path
from dispatches_sample_data import rts_gmlc
from dispatches_data.api import path
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this path related to pathlib's Path? The names seem a bit too similar

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is related in the sense that it's a function that returns a pathlib.Path object: https://dispatches-data-packages.readthedocs.io/en/latest/#dispatches_data.api.path.

As for whether the name is too similar: I think in general it's a fair point. I think I chose path() as opposed to e.g. get_path() to more closely resemble the importlib.resources API, where the "getters" are also named without the get_ prefix.

I'm open to revisit this (or add an alias, to preserve compatibility?), but this would have to be done in the gmlc-dispatches/data-packages repository first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with it

@dguittet dguittet self-requested a review May 24, 2023 14:09
Copy link
Contributor

@radhakrishnatg radhakrishnatg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @lbianchi-lbl for updating the notebooks!

@lbianchi-lbl lbianchi-lbl merged commit e1ef58b into gmlc-dispatches:main May 24, 2023
@lbianchi-lbl lbianchi-lbl deleted the rts-gmlc-data branch May 24, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Medium Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants