Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Prescient 2.2.2 or higher #193

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Require Prescient 2.2.2 or higher #193

merged 2 commits into from
Apr 4, 2023

Conversation

bknueven
Copy link
Collaborator

@bknueven bknueven commented Apr 4, 2023

Addresses issue:

Summary/Motivation:

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@bknueven bknueven marked this pull request as ready for review April 4, 2023 01:52
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a37c89b) 93.74% compared to head (57804cb) 93.74%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #193   +/-   ##
=======================================
  Coverage   93.74%   93.74%           
=======================================
  Files          59       59           
  Lines        7130     7130           
=======================================
  Hits         6684     6684           
  Misses        446      446           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@lbianchi-lbl lbianchi-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @bknueven (and the rest of the Prescient dev team) for the quick patch release!

@lbianchi-lbl lbianchi-lbl merged commit 935b6aa into main Apr 4, 2023
@bknueven bknueven deleted the prescient_222 branch April 4, 2023 16:39
lbianchi-lbl pushed a commit that referenced this pull request Apr 5, 2023
* Require Prescient 2.2.2 or higher

* rerun readthedocs and GHA

(cherry picked from commit 935b6aa)
@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants