Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests to dynamic surrogates #206

Merged
merged 34 commits into from
Jun 27, 2023

Conversation

Xinhe-Chen
Copy link
Contributor

Addresses issue:

Summary/Motivation:

Add more tests to dynamic surrogates. This PR is created for #195

Changes proposed in this PR:

  • Improve the codedev coverage.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@Xinhe-Chen
Copy link
Contributor Author

Still working in progress. I will get this PR ready for review before the RC.

@ksbeattie ksbeattie added the Priority:Normal Medium Priority Issue or PR label Jun 12, 2023
@lbianchi-lbl
Copy link
Contributor

@Xinhe-Chen @dguittet: see IDAES/idaes-pse#1200 for the pytest issue.

@lbianchi-lbl
Copy link
Contributor

@lbianchi-lbl and @Xinhe-Chen will touch base to solve the general testing issue this week.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 95.58% and project coverage change: +0.19 🎉

Comparison is base (e1771b4) 89.49% compared to head (e265596) 89.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   89.49%   89.69%   +0.19%     
==========================================
  Files          67       67              
  Lines        8238     8303      +65     
==========================================
+ Hits         7373     7447      +74     
+ Misses        865      856       -9     
Impacted Files Coverage Δ
...t_surrogates/dynamic/tests/test_Simulation_Data.py 97.90% <87.50%> (-2.10%) ⬇️
...arket_surrogates/dynamic/Time_Series_Clustering.py 37.67% <100.00%> (+1.98%) ⬆️
...n_market_surrogates/dynamic/Train_NN_Surrogates.py 28.75% <100.00%> (+1.18%) ⬆️
...gates/dynamic/tests/test_Time_Series_Clustering.py 99.24% <100.00%> (+0.16%) ⬆️
...rrogates/dynamic/tests/test_Train_NN_Surrogates.py 98.64% <100.00%> (+0.34%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lbianchi-lbl lbianchi-lbl enabled auto-merge (squash) June 26, 2023 17:01
@lbianchi-lbl lbianchi-lbl self-requested a review June 26, 2023 17:02
@lbianchi-lbl lbianchi-lbl disabled auto-merge June 27, 2023 17:39
@lbianchi-lbl lbianchi-lbl merged commit a2a7bb9 into gmlc-dispatches:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Medium Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test coverage for dispatches.workflow.train_market_surrogates
3 participants