Run more tests on both JVM/JS

[armanbilge]

fs2-io supports all APIs (including files) on JVM and JS now.

[satabin]

Hi @armanbilge and thanks for the contribution. One first question: why did you move all the main sources from shared to src. Sources in shared is used on bith JVM and JS platforms, so this should be no problem.

[armanbilge]

All the sources are shared now, so you can simplify your directory structure to an ordinary project (no need for shared/jvm/js split).

[satabin]

All the sources are shared now, so you can simplify your directory structure to an ordinary project (no need for shared/jvm/js split).

The main sources were already shared, but for sake of uniformity, I’d like to keep all modules use the shared structure, if that’s ok for you.

[armanbilge]

Sure no problem!

[armanbilge]

@satabin should I fix these modules as well?
https://github.com/satabin/fs2-data/blob/bf5a7033574d17c05cf408ef33a93b7792ec1d8a/build.sbt#L250-L251
https://github.com/satabin/fs2-data/blob/bf5a7033574d17c05cf408ef33a93b7792ec1d8a/build.sbt#L264-L265

[satabin]

@satabin should I fix these modules as well?

https://github.com/satabin/fs2-data/blob/bf5a7033574d17c05cf408ef33a93b7792ec1d8a/build.sbt#L250-L251

https://github.com/satabin/fs2-data/blob/bf5a7033574d17c05cf408ef33a93b7792ec1d8a/build.sbt#L264-L265

Damn. Ok nevermind, I need to have a global look at it. Keep it the way you have it.

[armanbilge]

Yes, actually it seems there are many more tests that can cross-compile now. Looking through quickly I see the CsvParserTest can also run on JS now.

[armanbilge]

I think the only module that actually needs split sources is csv, because URL is not supported on Scala.js. It looks to me like everything else 100% shares sources (JSON will be able too as well now.)

[satabin]

Ok thanks I need to do a global check on my use of shared, I thought I had more specific cases.

[ybasket]

I let two of you figure out the sbt sources setup, it's by far not my strength 🙄

But thank you very much for the work @armanbilge! Feel free to ping me on the Typelevel Discord (same handle) if you need more workflow approvals on the way.

[ybasket]

Looks good from my side then, but I'll let @satabin do the merge in case there's something with the source folders still to be optimised.

[satabin]

Looks good from my side then, but I'll let @satabin do the merge in case there's something with the source folders still to be optimised.

Nah, it’s fine, I’ll merge it. Thanks a lot @armanbilge!