Add return types for functions in tests (#815)

gnikyt · Jun 21, 2021 · 8abf4ad · 8abf4ad
1 parent 3438c96
commit 8abf4ad
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/tests/Messaging/Jobs/AppUninstalledTest.php b/tests/Messaging/Jobs/AppUninstalledTest.php
@@ -15,7 +15,7 @@ public function setUp(): void
         parent::setUp();
     }
 
-    public function testJobSoftDeletesShopAndCharges()
+    public function testJobSoftDeletesShopAndCharges(): void
     {
         // Create a plan
         $plan = factory(Plan::class)->states('type_recurring')->create();

diff --git a/tests/Services/CookieHelperTest.php b/tests/Services/CookieHelperTest.php
@@ -53,7 +53,7 @@ public function setUp(): void
     /**
      * Originally from @jedimdan in previous iteration.
      */
-    public function testSameSiteCookie()
+    public function testSameSiteCookie(): void
     {
         foreach ($this->badUserAgents as $agent) {
             $_SERVER['HTTP_USER_AGENT'] = $agent;

diff --git a/tests/Stubs/OrdersCreateJob.php b/tests/Stubs/OrdersCreateJob.php
@@ -24,7 +24,7 @@ public function __construct($shopDomain, $data)
         $this->data = $data;
     }
 
-    public function handle()
+    public function handle(): void
     {
         // Do what you wish with the data
     }

diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -54,7 +54,7 @@ protected function getEnvironmentSetUp($app): void
         $app['config']->set('auth.providers.users.model', UserStub::class);
     }
 
-    protected function setupDatabase($app)
+    protected function setupDatabase($app): void
     {
         // Run Laravel migrations
         $this->loadLaravelMigrations();
@@ -63,7 +63,7 @@ protected function setupDatabase($app)
         $this->artisan('migrate')->run();
     }
 
-    protected function swapEnvironment(string $env, Closure $fn)
+    protected function swapEnvironment(string $env, Closure $fn): void
     {
         // Get the current environemnt
         $currentEnv = App::environment();

diff --git a/tests/Traits/ShopModelTest.php b/tests/Traits/ShopModelTest.php
@@ -50,7 +50,7 @@ public function testOfflineToken(): void
         $this->assertTrue($shop->hasOfflineAccess());
     }
 
-    public function testNamespacingAndFreemium()
+    public function testNamespacingAndFreemium(): void
     {
         $this->app['config']->set('shopify-app.billing_freemium_enabled', true);
         $this->app['config']->set('shopify-app.namespace', 'app');