Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Undefined property $capped_amount #425

Closed
ghost opened this issue Mar 20, 2020 · 2 comments
Closed

Undefined property $capped_amount #425

ghost opened this issue Mar 20, 2020 · 2 comments
Assignees
Labels
bug Bug with the code fix-in-progress In progress

Comments

@ghost
Copy link

ghost commented Mar 20, 2020

Expected Behavior

will open the fare confirmation window

Current Behavior

error:
Undefined property: Osiset\ShopifyApp\Services\ChargeHelper::$capped_amount

if you make the 'capped_amount' null field, then everything is fine.

Steps to Reproduce

  1. install the application
  2. enable billing
  3. add a tariff plan from the example
  4. try to access the application
  5. error

Context

Package Version: v11.1.0
Laravel Version: v6.18.2
PHP Version: v7.2.2

Failure Logs

message: "Undefined property: Osiset\ShopifyApp\Services\ChargeHelper::$capped_amount"
exception: "ErrorException"
file: "/home/user/public_html/testApp/vendor/osiset/laravel-shopify/src/ShopifyApp/Services/ChargeHelper.php"
line: 267


and a separate issue:
is there an easy way to implement a change of tariff plan?
I did it through route redefinition, but it's not the best solution, to say the least.

@ghost
Copy link
Author

ghost commented Mar 23, 2020

kind of figured out what the problem was.

Shopify api recurringapplicationcharge expects 'terms' but 'cappedTerms' comes in the request.

in vendor/osiset/laravel-shopify/src/ShopifyApp/Services/ChargeHelper.php.

@gnikyt gnikyt self-assigned this Mar 25, 2020
@gnikyt gnikyt added fix-in-progress In progress bug Bug with the code labels Mar 25, 2020
@gnikyt
Copy link
Owner

gnikyt commented Mar 25, 2020

Please try v11.2.0

@ghost ghost closed this as completed Mar 25, 2020
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bug with the code fix-in-progress In progress
Projects
None yet
Development

No branches or pull requests

1 participant