-
-
Notifications
You must be signed in to change notification settings - Fork 376
Conversation
…as this stops the need for the session to have the user which is unrelable and it matches how the other two billing methods work.
…validation on the usage charge and over complicates the code as an exception will be thrown if it is missing in the req params.
Hey @osiset I've updated the usage charge wiki as it was not passing over the signature as a string but as it is breaking As the other methods, just pass in the shop domain, it made sense to just keep it consistent. When merged I'll update the wiki to pass in the shop domain also. Issues relate: Here's the charge in the DB successfully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment there.. up to you if you think its a better method or not.
Is there any need to add |
@nahid no need to pass the verify middleware, that is why the shop param is passed along. It also follows how the plan billing routes work, so it keeps the logic consistent with other parts of the app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good by me.
Edit: Merging #1222 will fix PHP8.0 run
@osiset merged in #1222 now so if you are happy, will merge this into master and do a small patch release |
@Kyon147 Go ahead :) |
Currently, the usage Charge method is trying to get the user from the session but it is not available.
This updates the route to expect the shop domain to be passed in like the other functions.