-
-
Notifications
You must be signed in to change notification settings - Fork 376
Feature/webhooks graphql support #796
Feature/webhooks graphql support #796
Conversation
* Combining AuthShopify, AuthToken into new VerifyShopify middleware * SessionToken value object created to verify and validate all aspects of the JWT * New unauthenticated route and view added
* VerifyShopify: Cleaned up methods to be smaller and clearer * VerifyShopify: Handle cases for no token, no hmac * VerifyShopify: Adjusted to not rely on ShopSession service anymore.
* Moved AuthorizeShop to InstallShop * Condensed InstallShop and modified to return an array * Modified InstallShop to track access token update time * Modified Shop command to track access token update time
* Removed authenticate.oauth route * Removed oauthfailure method on authenticate controller * Removed ShopSession class * Updated shopify-config to reference new authenticate routes (install, token) * Updated shopify-config to remove old authenticate routes * Updated ShopModel's getToken to getAccessToken for naming conflict purposes * Removed old ITP and authenticate routes from built-in route provider
…' into feature/webhooks-graphql-support
800-Freemium mode uninstall flag added on webhook (gnikyt#801)
Feature/webhooks graphql support
Feature/cookieless
Looks fine, is there any breaking changes you noticed? Or are webhooks running as normal? |
There's only one breaking change; Webhook definitions is currently like this:
GraphQL API requires topics as depicted in this list: And that makes the new definitions should be:
|
@onurkose Ah! Can you update config/shopify-app.php to reflect this? Thanks! Should be good to merge then if you're seeing no functional issues. |
This is helpful, thanks for creating this pull request @onurkose |
It's done! Yes, we are using a forked-version of this one on production right now and no issues at all. |
…' into feature/webhooks-graphql-support
@onurkose why the close? |
I had (mistakenly) cookieless branch merged&pushed over this one, tried to reset the branch but couldn't succeed it without deleting the origin/remote. When I deleted the remote branch github closed the pr itself. Here is the new one. |
Hello!
I needed to subscribe to app_subscriptions/update webhook, and it only supports GraphQL.
I've made the necessary changes to implement GraphQL support to webhooks CRUD ops.
Thanks for the great package btw.