-
-
Notifications
You must be signed in to change notification settings - Fork 376
UPDATE: configurable auth provider #934
UPDATE: configurable auth provider #934
Conversation
Sounds good to me! Please see the failed lint, adjust, and I'll merge :) |
@lucasmichot thanks for the fix, @osiset if there's anything else wrong with current PR - please let me know. |
UPDATE: added config option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small issues to correct linting, then can be merged.
Checks passed, linting pass. Merging. Thanks @vkislichenko ! |
What about the migrations ? they still change the user model |
there's "Manual migrations" in config |
When this changes will be released? @osiset |
I'm sure there is a valid reasoning behind current logic of extending User model with shopify shop trait,
But I really do need them to be separate.
This PR provides one more shopify app config option
shop_auth_provider
("users" by default)Model is then taken from config
auth.providers.{$config['shop_auth_provider']}.model
Works if manual migrations are used and user table is replaced with custom one
Models provided by this package will still reference custom model using
user_id
columns, but it seems like a minor detail related to bigger refactoring.