Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the Sign up screen, check if the account name already exists on the phone/blockchain #72

Closed
jefft0 opened this issue May 16, 2024 · 1 comment · Fixed by #116
Closed
Labels
bug Something isn't working verified Bug is verified

Comments

@jefft0
Copy link
Contributor

jefft0 commented May 16, 2024

The Sign up screen creates an account on the phone and then calls onboarding to register with r/demo/users on the blockchain. But the account names in the keystore on the phone and the blockchain are linked. If the account name already exists in r/demo/users, then oboarding fails to register with r/demo/users. And the keystore on the phone may have an account with the same name but different addresses.

We need to keep the keystore in sync with r/demo/users when the user enters name N on the signup screen. The following table covers all cases and the action to take.

Request name N.

N in keystore? N in r/demo/users? same addr? action
yes yes yes Offer to do normal signin, or choose new N
yes yes no Bad case. Choose new N. (Delete N in keystore?)
yes no X Offer to onboard existing account (check if need faucet to add coins), replace it, or choose new N
no yes yes (keystore has same r/demo/users addr with different N2.) Offer to recreate as N in keystore, do signin.
no yes no (keystore doesn't have r/demo/users addr.) Name is unavailable. Choose new N
no no X Create name/addr in keystore, register in r/demo/users
@jefft0 jefft0 added bug Something isn't working verified Bug is verified and removed 🚀 feature-request labels May 27, 2024
@jefft0 jefft0 changed the title In the Sign up screen, check if the account name already exists on the blockchain In the Sign up screen, check if the account name already exists on the phone/blockchain Jun 19, 2024
@jefft0
Copy link
Contributor Author

jefft0 commented Jun 24, 2024

For "rename key", perhaps use PrivKey directly (instead of Keybase) like the faucet does here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verified Bug is verified
Projects
None yet
1 participant