Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: onboarding new users #116

Merged
merged 22 commits into from
Jul 24, 2024
Merged

chore: onboarding new users #116

merged 22 commits into from
Jul 24, 2024

Conversation

iuricmp
Copy link
Contributor

@iuricmp iuricmp commented Jul 11, 2024 •
edited
Loading

fix #72

@iuricmp iuricmp requested a review from jefft0 July 17, 2024 10:14
@iuricmp iuricmp marked this pull request as ready for review July 17, 2024 10:14
@iuricmp
chore: redux
4cbe14e 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp
chore: update signupt and progress view
7bfc9d2 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp
chore: existing user message
ecd726b 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp
refactor: rename
2f19ce9 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp
chore: onboarding
8a79c81 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp
feat: sharing console
d719a0f 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp
chore: progress ui improvments
866d7b6 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp
chore: improvments
3c01e56 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp
chore: display error msg on 1.1
ba6205a 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp
chore: cleaning up error
e6a6f55 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp
chore: chatch up errors
e76dcfe 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp
chore: improvments
84de878 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp
chore: local account
05cef4f 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp
chore: add error message
3cf001b 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp
chore: changing error message
2bc36b9 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp
chore: using GetJsonUserByName
eacfdd6 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp iuricmp requested a review from jefft0 July 17, 2024 17:11
@iuricmp
chore: registering address
eb76283 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp
chore: removing duplicated code
e794442 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp
fix: onboarding
5d9bb01 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@jefft0 jefft0 mentioned this pull request Jul 19, 2024
Closed
@iuricmp
chore: upgrading gnonative
682c9d2 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp
chore: fixing onboarding scenarios
4f2e3c6 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
jefft0
jefft0 reviewed Jul 24, 2024
View reviewed changes
mobile/app/sign-up.tsx Outdated Show resolved Hide resolved
jefft0
jefft0 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@jefft0 jefft0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my one comment about the error messsage. Tested the use cases in #72 on Android and iOS simulators.

@iuricmp
refactor: changing label
df5b3fb 
Signed-off-by: Iuri Pereira <689440+iuricmp@users.noreply.github.com>
@iuricmp iuricmp merged commit d5109ca into main Jul 24, 2024
@iuricmp iuricmp deleted the refactor/api-from-redux branch July 24, 2024 14:54
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefft0 jefft0 jefft0 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In the Sign up screen, check if the account name already exists on the phone/blockchain
2 participants
@iuricmp @jefft0