Skip to content

Commit

Permalink
ci: fix broken CI, always test all go code (#2625)
Browse files Browse the repository at this point in the history
There's been another CI fail on master just now, because changes in
examples/ were changing the golden output in gnovm/, but gnovm/ was not
tested.

This PR implements the suggestion I made in #2531 - ie. not
discriminating CIs based on the paths of the modified file.
  • Loading branch information
thehowl authored Jul 24, 2024
1 parent 691a1ba commit 0e3c050
Show file tree
Hide file tree
Showing 8 changed files with 190 additions and 54 deletions.
13 changes: 2 additions & 11 deletions .github/workflows/contribs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,7 @@ on:
branches:
- master
workflow_dispatch:
pull_request:
paths:
- "contribs/**"
- ".github/**"
# Contribs directly depend on gno, so we need to test it whenever changes
# are made to one of those
- "go.*" # check on go.mod/sum update
- "gno.land/**"
- "tm2/**.go"
- "gnovm/**.go"
pull_request:

jobs:
setup:
Expand All @@ -24,7 +15,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- id: set-matrix
run: echo "::set-output name=programs::$(ls -d contribs/*/ | cut -d/ -f2 | jq -R -s -c 'split("\n")[:-1]')"
run: echo "::set-output name=programs::$(ls -d contribs/*/ | cut -d/ -f2 | jq -R -s -c 'split("\n")[:-1]')"
main:
needs: setup
strategy:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dependabot-tidy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
run: |
# Ensure Make is installed
make --version
# Run the tidy target
make tidy
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/examples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@ name: examples

on:
pull_request:
paths:
- "go.sum"
- "gnovm/**"
- "examples/**"
- ".github/workflows/examples.yml"
push:
branches: [ "master" ]

Expand Down
7 changes: 0 additions & 7 deletions .github/workflows/gnoland.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,6 @@ on:
- master
workflow_dispatch:
pull_request:
paths:
- "gno.land/**"
- "tm2/**.go"
- "gnovm/**.go"
- "go.*" # check on go.mod/sum update
- ".github/**"
- "examples/**"

jobs:
main:
Expand Down
6 changes: 1 addition & 5 deletions .github/workflows/gnovm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,7 @@ on:
branches:
- master
workflow_dispatch:
pull_request:
paths:
- "gnovm/**"
- "go.*" # check on go.mod/sum update
- ".github/**"
pull_request:

jobs:
main:
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/misc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,7 @@ on:
branches:
- master
workflow_dispatch:
pull_request:
paths:
- "misc/**"
- ".github/**"
pull_request:

jobs:
main:
Expand All @@ -32,4 +29,4 @@ jobs:
with:
modulepath: misc/${{ matrix.program }}
secrets:
codecov-token: ${{ secrets.CODECOV_TOKEN }}
codecov-token: ${{ secrets.CODECOV_TOKEN }}
4 changes: 0 additions & 4 deletions .github/workflows/tm2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ on:
- master
workflow_dispatch:
pull_request:
paths:
- "tm2/**"
- "go.*" # check on go.mod/sum update
- ".github/**"

jobs:
main:
Expand Down
Loading

0 comments on commit 0e3c050

Please sign in to comment.