Skip to content

Commit

Permalink
Drop name from dao.Member
Browse files Browse the repository at this point in the history
  • Loading branch information
zivkovicmilos committed Jul 14, 2024
1 parent 00056a5 commit 209ee06
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
8 changes: 3 additions & 5 deletions examples/gno.land/p/demo/simpledao/membstore_test.gno
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ func generateMembers(t *testing.T, count int) []dao.Member {
for i := 0; i < count; i++ {
members = append(members, dao.Member{
Address: testutils.TestAddress(ufmt.Sprintf("member %d", i)),
Name: "test member",
VotingPower: 10,
})
}
Expand Down Expand Up @@ -87,7 +86,6 @@ func TestMembStore_GetMembers(t *testing.T) {
}

uassert.Equal(t, member.VotingPower, fetchedMember.VotingPower)
uassert.Equal(t, member.Name, fetchedMember.Name)
}
}
})
Expand Down Expand Up @@ -270,11 +268,11 @@ func TestMembStore_UpdateMember(t *testing.T) {
members := generateMembers(t, 1)
m := NewMembStore(WithInitialMembers(members))

name := "new name!"
members[0].Name = name
votingPower := uint64(300)
members[0].VotingPower = votingPower

// Attempt to update a member
uassert.NoError(t, m.UpdateMember(members[0].Address, members[0]))
uassert.Equal(t, name, m.GetMembers()[0].Name)
uassert.Equal(t, votingPower, m.GetMembers()[0].VotingPower)
})
}
1 change: 0 additions & 1 deletion examples/gno.land/p/gov/dao/members.gno
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,5 @@ type MemberStore interface {
// Member holds the relevant member information
type Member struct {
Address std.Address // bech32 gno address of the member (unique)
Name string // name associated with the member
VotingPower uint64 // the voting power of the member
}

0 comments on commit 209ee06

Please sign in to comment.