Add unit tests for subs

contribs/gnostats/server/server.go

@@ -37,7 +37,7 @@ type Hub struct {
 // NewHub creates a new hub instance
 func NewHub() *Hub {
 	return &Hub{
-		subs: &subs{},
+		subs: make(subs),
 	}
 }
 

contribs/gnostats/server/subs.go

@@ -15,32 +15,32 @@ type (
 )
 
 // subscribe creates a new data stream subscription
-func (s *subs) subscribe() (xid.ID, dataStream) {
+func (s subs) subscribe() (xid.ID, dataStream) {
 	var (
 		id = xid.New()
 		ch = make(dataStream, 1)
 	)
 
-	(*s)[id] = ch
+	s[id] = ch
 
 	return id, ch
 }
 
 // unsubscribe removes the given subscription
-func (s *subs) unsubscribe(id xid.ID) {
-	if ch := (*s)[id]; ch != nil {
+func (s subs) unsubscribe(id xid.ID) {
+	if ch := s[id]; ch != nil {
 		// Close the notification channel
 		close(ch)
 	}
 
 	// Delete the subscription
-	delete(*s, id)
+	delete(s, id)
 }
 
 // notify notifies all subscription listeners
-func (s *subs) notify(data *proto.DataPoint) {
+func (s subs) notify(data *proto.DataPoint) {
 	// Notify the listeners
-	for _, ch := range *s {
+	for _, ch := range s {
 		select {
 		case ch <- data:
 		default:

contribs/gnostats/server/subs_test.go

@@ -0,0 +1,75 @@
+package server
+
+import (
+	"sync"
+	"testing"
+	"time"
+
+	"github.com/gnolang/gnostats/proto"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestSubs_Subscribe(t *testing.T) {
+	t.Parallel()
+
+	s := make(subs)
+
+	id, ch := s.subscribe()
+	require.NotNil(t, id)
+	require.NotNil(t, ch)
+
+	assert.Len(t, s, 1)
+}
+
+func TestSubs_Unsubscribe(t *testing.T) {
+	t.Parallel()
+
+	s := make(subs)
+
+	id, _ := s.subscribe()
+	require.NotNil(t, id)
+
+	require.Len(t, s, 1)
+
+	s.unsubscribe(id)
+	assert.Len(t, s, 0)
+}
+
+func TestSubs_Notify(t *testing.T) {
+	t.Parallel()
+
+	var (
+		s             = make(subs)
+		receivedPoint *proto.DataPoint
+
+		dataPoint = generateDataPoints(t, 1)[0]
+	)
+
+	id, ch := s.subscribe()
+	require.NotNil(t, id)
+	require.NotNil(t, ch)
+
+	defer s.unsubscribe(id)
+
+	var wg sync.WaitGroup
+
+	wg.Add(1)
+
+	go func() {
+		defer wg.Done()
+
+		select {
+		case <-time.After(5 * time.Second):
+		case receivedPoint = <-ch:
+		}
+	}()
+
+	s.notify(dataPoint)
+
+	wg.Wait()
+
+	assert.Equal(t, dataPoint.StaticInfo.Address, receivedPoint.StaticInfo.Address)
+	assert.Equal(t, dataPoint.StaticInfo.GnoVersion, receivedPoint.StaticInfo.GnoVersion)
+	assert.Equal(t, dataPoint.StaticInfo.OsVersion, receivedPoint.StaticInfo.OsVersion)
+}