Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(bug): sidebar popping out over the footer with long pages or large zoom #1513

Closed
leohhhn opened this issue Jan 10, 2024 · 1 comment
Closed

docs(bug): sidebar popping out over the footer with long pages or large zoom #1513

leohhhn opened this issue Jan 10, 2024 · 1 comment
Assignees
@alexiscolin
Labels
📖 documentation Improvements or additions to documentation 🐞 bug Something isn't working

Comments

@leohhhn
Copy link
Contributor

leohhhn commented Jan 10, 2024

Description

I've noticed a small UI bug in the documentation. Currently, the documentation page has a right sidebar that shows the page outline and its headers. When this sidebar is sufficiently long, it can pop out of the main page body and end up overlapping the footer.

Here is a 1-minute Loom video explaining what I am talking about.
@leohhhn leohhhn added 📖 documentation Improvements or additions to documentation 🐞 bug Something isn't working labels Jan 10, 2024
@alexiscolin alexiscolin mentioned this issue Jan 10, 2024
Merged
thehowl added a commit that referenced this issue Jan 10, 2024
@alexiscolin @thehowl
style: improve docs links, toc and icons (#1516)
26ad8dd 
Last polish docs website design by:

- Limiting ToC height and allowing scroll inside (cf #1513)
- Replacing external icon
- Adding the full logo
- Improving the caret icon
- Fixing Toc hover color on dark mode

---------

Co-authored-by: Morgan <git@howl.moe>
@leohhhn
Copy link
Contributor Author

leohhhn commented Jan 10, 2024

Closing as the bug was fixed in #1516. Thanks @alexiscolin @thehowl!

@leohhhn leohhhn closed this as completed Jan 10, 2024
gfanton pushed a commit to moul/gno that referenced this issue Jan 18, 2024
@alexiscolin @thehowl @gfanton
style: improve docs links, toc and icons (gnolang#1516)
e62d6fb 
Last polish docs website design by:

- Limiting ToC height and allowing scroll inside (cf gnolang#1513)
- Replacing external icon
- Adding the full logo
- Improving the caret icon
- Fixing Toc hover color on dark mode

---------

Co-authored-by: Morgan <git@howl.moe>
@zivkovicmilos zivkovicmilos mentioned this issue Jan 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexiscolin alexiscolin

Labels
📖 documentation Improvements or additions to documentation 🐞 bug Something isn't working
Projects
🚀 The Launch [DEPRECATED]
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexiscolin @leohhhn