Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chain] Populate func field in emitted events #2001

Closed
zivkovicmilos opened this issue Apr 30, 2024 · 2 comments
Closed

[chain] Populate func field in emitted events #2001

zivkovicmilos opened this issue Apr 30, 2024 · 2 comments
Assignees
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related

Comments

@zivkovicmilos
Copy link
Member

Description

This task concerns populating the func field (function name) for the emitted events following #1653.

Copying the discussion from the PR:

@moul:

The func field is empty, and should not, I think we should take the most recent "named" frame.

@notJoon:

In the second case, where the function name is empty, it seems that the function name cannot be retrieved from the stack frame only for special purpose functions such as anonymous functions (or lambda functions) used in callbacks or defer, or test functions.

cc @Kouteki

@r3v4s
Copy link
Contributor

r3v4s commented May 22, 2024

#2160 PR iterates more previous frame than current, to handle func name.

@zivkovicmilos zivkovicmilos moved this from Todo to In Progress in 🧙‍♂️gno.land core team May 23, 2024
thehowl pushed a commit that referenced this issue Jul 2, 2024
<!-- please provide a detailed description of the changes made in this
pull request. -->

Closes #2002

Also related to #2001 




<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
@zivkovicmilos
Copy link
Member Author

Closed by #2160

@github-project-automation github-project-automation bot moved this from Backlog to Done in 🤝🏻 Partner: Onbloc Jul 4, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in 🧙‍♂️gno.land core team Jul 4, 2024
gfanton pushed a commit to gfanton/gno that referenced this issue Jul 23, 2024
<!-- please provide a detailed description of the changes made in this
pull request. -->

Closes gnolang#2002

Also related to gnolang#2001 




<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Development

No branches or pull requests

3 participants