-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gnokey] Make gnokey query
more convenient
#2349
Comments
The I believe it should remain this way, so we can rely on Your second idea about adding subcommands (while preserving the current implementation) sounds good to me. Alternatively, we could create new But IMO, subcommands are OK, since The new subcommands should not have any implementation in |
Description
This issue related to a few issues in
gnokey
, specifically related to how we parse data when doing an ABCI query to the chain.In this case, I am referring mainly to
vm/...
queries.Currently, the
--data
flag takes in all of the data for the query, but this is inconvenient because of the way parsing works - see this issue for example.Another issue that we have is that we cannot currently list available ABCI queries via the CLI - you either have to go to the docs, or read the code.
I have two proposals:
--data
flag into --pkgpath &--func
/--arg
or similar - this approach could work, but onlyonetwo queries currently, ievm/qeval
&vm/qrender
, actually take in more than the package path. It would make a mismatch/useless flags for other current queries, and it could create a problem when/if we add more ABCI queries.query
. This would enable us to have subcommand-specific flags, and have them have their own proper flags. This approach would be more clean, but it would also limit the addition of new ones, since the subcommands could pile up over time if we choose to add more and more queries.Both of the above proposals have both pros & cons, but I believe that it could be the way forward, as we might not be adding more subqueries in the future. It would be a compromise.
I would like to hear input on this @moul @zivkovicmilos @ajnavarro @thehowl
The text was updated successfully, but these errors were encountered: