Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keeper)!: use <pkgpath>.<expr> syntax for qeval; <pkgpath>:<path> for qrender #2382

Merged
merged 7 commits into from
Jun 20, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Jun 18, 2024

This is a switch that was discussed with @leohhhn and @moul. It switches the current syntax for qeval, which requires a newline as a separator, to use a dot . instead (ie. gno.land/r/demo/users.MyFunction(123)). For qrender, this is switched to a colon :, like the gnoweb render: gno.land/r/demo/users:u/morgan.

BREAKING CHANGE: current qeval and qrender calls using the RPC endpoints will have to be changed. No changes are required for gnoclient users.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@thehowl thehowl self-assigned this Jun 18, 2024
@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Jun 18, 2024
@leohhhn
Copy link
Contributor

leohhhn commented Jun 18, 2024

Related: #2349

thehowl and others added 3 commits June 18, 2024 14:07
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.64%. Comparing base (7b8a893) to head (73772ba).
Report is 9 commits behind head on master.

Files Patch % Lines
gno.land/pkg/sdk/vm/handler.go 64.70% 6 Missing ⚠️
gno.land/pkg/gnoclient/client_queries.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2382      +/-   ##
==========================================
+ Coverage   54.63%   54.64%   +0.01%     
==========================================
  Files         582      582              
  Lines       78401    78402       +1     
==========================================
+ Hits        42832    42843      +11     
+ Misses      32359    32349      -10     
  Partials     3210     3210              
Flag Coverage Δ
gno.land 62.22% <66.66%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leohhhn
Copy link
Contributor

leohhhn commented Jun 19, 2024

Codecov? :c

@thehowl thehowl merged commit 032d422 into master Jun 20, 2024
75 checks passed
@thehowl thehowl deleted the dev/morgan/qeval-newlines branch June 20, 2024 11:51
@zivkovicmilos zivkovicmilos added the breaking change Functionality that contains breaking changes label Jun 24, 2024
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
…> for qrender (gnolang#2382)

This is a switch that was discussed with @leohhhn and @moul. It switches
the current syntax for qeval, which requires a newline as a separator,
to use a dot `.` instead (ie. `gno.land/r/demo/users.MyFunction(123)`).
For qrender, this is switched to a colon `:`, like the gnoweb render:
`gno.land/r/demo/users:u/morgan`.

BREAKING CHANGE: current qeval and qrender calls using the RPC endpoints
will have to be changed. No changes are required for gnoclient users.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [x] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

---------

Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Functionality that contains breaking changes 📦 ⛰️ gno.land Issues or PRs gno.land package related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done