fix: remove ambiguous import by downgrading btcutil v1.1.1 to v1.0.0 #1064
Conversation
Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
There was a problem hiding this comment.
I'm approving this PR because Git history points to the fact that the btcd/btcutil/bech32 directory has been untouched since its creation: https://github.com/btcsuite/btcd/commits/master/btcutil/bech32
In our code base, the single use for the btcd/btcutil module is for bech32:
$ rg -t go btcutil
tm2/pkg/bech32/bech32.go
4: "github.com/btcsuite/btcd/btcutil/bech32"
tm2/pkg/crypto/secp256k1/secp256k1_test.go
8: "github.com/btcsuite/btcutil/base58"
(Note the second match is of a different module, untouched by this PR, and on top of things in a test file)
So downgrading this dependency will effectively not change anything in the code that we use, while unblocking berty in their development. I'll still be noting to try to resolve this btcd dependency mess :)
|
@piux2 Check out the repository. You will see that for the btcutil module, since we only use bech32, for us v1.0.0 is effectively the same as v1.1.1. |
|
@thehowl Yes, you are right. Thank you for pointing out! At the time, when btcutil v1.0.2 was in a separate repo, it did not have DecodeNoLimit() in bech32.go. Later, when we fixed issue 241 we chose to use btcd/btcutil v1.1.1 . I guess they made DecodeNoLimit() available for btcd/btcutil v1.0.0, when they merged btcutil to btcd repo. That is where the confusion was from It is all good now. |
…nolang#1064) This PR fixes gnolang#1063. It downgrades `github.com/btcsuite/btcd/btcutil v1.1.1` to `v1.0.0` to resolve conflicts in the dependency graph for the `github.com/btcsuite/btcd` package and its dependencies. More information can be found in the issue above. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [x] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
This PR fixes #1063.
It downgrades
github.com/btcsuite/btcd/btcutil v1.1.1tov1.0.0to resolve conflicts in the dependency graph for thegit.luolix.top/btcsuite/btcdpackage and its dependencies.More information can be found in the issue above.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description