-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(paginate): re-open PR with #883's work #1090
Conversation
Hi @tbruyelle tried to modify the previous PR's target branch via github but this created a strange merge commit so as mentionned by @thehowl I will continue here |
I think it would be better to migrate your
|
Let's close the previous PR then. |
yes better this way 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Isma <71719097+Doozers@users.noreply.github.com>
Signed-off-by: Isma <71719097+Doozers@users.noreply.github.com>
c2b9c6f
to
216c9ee
Compare
Hello @tbruyelle . You approved this pagination PR a year ago. Now there is a new PR from moul with two approvals. #2584 . Should this PR be closed in favor of the new one? |
Well, tbh, right now I don't have the time to dive into this code a year after I first looked at it, but I trust that moul has done a better job, so yeah, let's close this PR. |
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description