fix(codecov): merge coverage for a single upload by workflow #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1190 +/- ##
==========================================
+ Coverage 47.01% 47.39% +0.37%
==========================================
Files 365 367 +2
Lines 61156 62118 +962
==========================================
+ Hits 28753 29439 +686
- Misses 30039 30290 +251
- Partials 2364 2389 +25 ☔ View full report in Codecov by Sentry. |
moul
approved these changes
Oct 3, 2023
gfanton
added a commit
to gfanton/gno
that referenced
this pull request
Nov 9, 2023
…#1190) It appears that the retry system introduced in gnolang#1186 was not sufficient, as we still hit API limits when running multiple checks concurrently. This PR merges all coverage files into a single upload at the of each testing workflows. As a result, we now have 3 uploads instead of 16, which should drastically reduce the number of Codecov upload failures. Note: It still appears to fail randomly, but we might need to wait some time until our API rate decreases. I believe it's still preferable to have 3 uploads rather than 16, which seemed to overwhelm Codecov. --------- Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that the retry system introduced in #1186 was not sufficient, as we still hit API limits when running multiple checks concurrently.
This PR merges all coverage files into a single upload. As a result, we now have 3 uploads instead of 16, which should drastically reduce the number of Codecov upload failures.
Note: It still appears to fail randomly, but we might need to wait some time until our API rate decreases. I believe it's still preferable to have 3 uploads rather than 16, which seemed to overwhelm Codecov.