feat: improve gno linter with basic errors support #1202

gfanton · 2023-10-06T21:15:03Z

I've improved the linter by using RunMemPackage in the same way that gno test does for testing.
A direct use case for this PR is to provide a simple and reliable method for editors to integrate gno linting.

(There might be a better way to achieve what I've done, of which I'm not aware)

Below a sample of `gno lint` output:

And here's a brief demo using basic integration with emacs:

Contributors' checklist...

Added new tests, or not needed, or not feasible
Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
Updated the official documentation or not needed
No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
Added references to related issues and PRs
Provided any useful hints for running manual tests
Added new benchmarks to generated graphs, if any. More info here.

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

from `testscripts` doc.go: UpdateScripts specifies that if a `cmp` command fails and its second argument refers to a file inside the testscript file, the command will succeed and the testscript file will be updated to reflect the actual content (which could be stdout, stderr or a real file). The content will be quoted with txtar.Quote if needed; a manual change will be needed if it is not unquoted in the script. Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

codecov · 2023-10-06T21:24:38Z

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (6112ffd) 55.95% compared to head (0e4dad1) 56.05%.

Files	Patch %	Lines
gnovm/cmd/gno/lint.go	86.58%	9 Missing and 2 partials ⚠️
gnovm/tests/file.go	33.33%	4 Missing ⚠️
gnovm/pkg/gnolang/preprocess.go	77.77%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1202      +/-   ##
==========================================
+ Coverage   55.95%   56.05%   +0.10%     
==========================================
  Files         435      435              
  Lines       66306    66409     +103     
==========================================
+ Hits        37101    37228     +127     
+ Misses      26303    26287      -16     
+ Partials     2902     2894       -8

Flag	Coverage Δ
go-1.21.x	`∅ <ø> (∅)`
misc	`∅ <ø> (∅)`
misc-_test.genstd	`∅ <ø> (∅)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

gnovm/pkg/gnolang/preprocess.go

gnovm/cmd/gno/lint.go

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

moul · 2023-10-09T19:03:24Z

Related with #1215.

gnovm/tests/integ/undefined-variable-test/undefined_variables_test.gno

gnovm/cmd/gno/lint_test.go

gnovm/pkg/gnolang/preprocess.go

gnovm/cmd/gno/lint.go

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

thehowl

is there a test that makes sure that the preprocess stack is still printed in other places (ie. a normal stacktrace?)

thx

gnovm/cmd/gno/lint.go

gnovm/pkg/gnolang/debug.go

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

moul

can you add an example in CONTRIBUTING.md to use it with your editor?

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

gfanton · 2023-12-11T16:26:29Z

@moul added integration for emacs + vim (Im not sure this is the usual way for the last one, but at last it works)

gfanton added 5 commits October 6, 2023 21:44

feat: improve linter

ba33912

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

chore: cleanup gnoland preprocess output

0effbbf

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

feat: add some linter testscripts tests

fd891a2

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

chore: lint files

e53f017

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

gfanton self-assigned this Oct 6, 2023

gfanton requested review from jaekwon, moul and a team as code owners October 6, 2023 21:15

Merge branch 'master' into feat/gnolint-error

708092b

github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Oct 6, 2023

gfanton requested a review from harry-hov October 6, 2023 21:56

gfanton added 2 commits October 7, 2023 11:29

fix: add standard test

3ff3b43

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

fix: add lint test for _test files

5eb43c4

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

gfanton force-pushed the feat/gnolint-error branch from 0297418 to 5eb43c4 Compare October 7, 2023 12:54

moul reviewed Oct 7, 2023

View reviewed changes

gnovm/pkg/gnolang/preprocess.go Show resolved Hide resolved

moul reviewed Oct 7, 2023

View reviewed changes

gnovm/cmd/gno/lint.go Show resolved Hide resolved

chore: lint

ec53732

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

gfanton changed the title ~~feat: improve gno linter~~ feat: improve gno linter with basic errors support Oct 9, 2023

moul mentioned this pull request Oct 9, 2023

Provide clarification on the testing strategy and guidelines. #1215

Open

Merge branch 'master' into feat/gnolint-error

1e556c7

thehowl self-requested a review October 12, 2023 16:30

thehowl mentioned this pull request Oct 12, 2023

Minutes: GitHub Review Meetings [every Thursday] gnolang/meetings#18

Open

3 tasks

tbruyelle reviewed Oct 12, 2023

View reviewed changes

gnovm/tests/integ/undefined-variable-test/undefined_variables_test.gno Show resolved Hide resolved

tbruyelle reviewed Oct 12, 2023

View reviewed changes

gnovm/cmd/gno/lint_test.go Show resolved Hide resolved

thehowl reviewed Oct 20, 2023

View reviewed changes

gnovm/pkg/gnolang/preprocess.go Show resolved Hide resolved

gnovm/cmd/gno/lint.go Outdated Show resolved Hide resolved

github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Oct 20, 2023

feat: add preprocess stack error

145c78f

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

gfanton requested a review from thehowl October 20, 2023 16:59

fix: repl test

a628c94

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

thehowl reviewed Oct 23, 2023

View reviewed changes

gfanton added 4 commits October 23, 2023 15:00

fix: handle preprocess error on test

984841e

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

chore: lint

d40cf0f

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

Merge remote-tracking branch 'origin/master' into feat/gnolint-error

0f5c9de

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

chore: lint

c2c9656

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

zivkovicmilos mentioned this pull request Dec 5, 2023

Minutes: Core Staff Weekly Syncs [every Monday] gnolang/meetings#36

Open

gfanton added 9 commits December 6, 2023 15:52

Merge remote-tracking branch 'origin/master' into feat/gnolint-error

caf6442

fix: gno run test for preprocess stack

14251e6

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

chore: encapsulate error catch for better readability

89ae08f

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

fix: lint

11f101a

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

fix: bad rebase

d0f7245

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

fix: global lint

8b828b0

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

fix: linter

4b69afe

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

feat: add update scripts

af22e23

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

chore: update golden file

0540dc3

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

moul approved these changes Dec 7, 2023

View reviewed changes

gfanton added 4 commits December 7, 2023 23:48

Merge branch 'master' into feat/gnolint-error

2f160cf

fix: normalize lint error

3fb3b71

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

chore: update contributing md

3a444e0

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

fix: update golden files

fdc0c10

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>

zivkovicmilos self-requested a review December 11, 2023 16:11

gfanton requested a review from thehowl January 11, 2024 15:04

gfanton added 2 commits January 15, 2024 09:49

Merge branch 'master' into feat/gnolint-error

845ab7c

Merge branch 'master' into feat/gnolint-error

0e4dad1

gfanton requested a review from piux2 as a code owner January 22, 2024 13:36

thehowl approved these changes Jan 22, 2024

View reviewed changes

thehowl merged commit d6243b4 into gnolang:master Jan 22, 2024
189 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: improve gno linter with basic errors support #1202

feat: improve gno linter with basic errors support #1202

gfanton commented Oct 6, 2023 •

edited

Loading

codecov bot commented Oct 6, 2023 •

edited

Loading

moul commented Oct 9, 2023

thehowl left a comment

moul left a comment

gfanton commented Dec 11, 2023

feat: improve gno linter with basic errors support #1202

feat: improve gno linter with basic errors support #1202

Conversation

gfanton commented Oct 6, 2023 • edited Loading

Below a sample of gno lint output:

And here's a brief demo using basic integration with emacs:

codecov bot commented Oct 6, 2023 • edited Loading

Codecov Report

moul commented Oct 9, 2023

thehowl left a comment

Choose a reason for hiding this comment

moul left a comment

Choose a reason for hiding this comment

gfanton commented Dec 11, 2023

gfanton commented Oct 6, 2023 •

edited

Loading

Below a sample of `gno lint` output:

codecov bot commented Oct 6, 2023 •

edited

Loading