Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove import cycle in test files #1206

Closed

Conversation

harry-hov
Copy link
Contributor

@harry-hov harry-hov commented Oct 8, 2023

See #1394

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Oct 8, 2023
@harry-hov harry-hov changed the title chore: remove import cycle for test files chore: remove import cycle in test files Oct 8, 2023
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.81%. Comparing base (fa8eb77) to head (0f5629d).
Report is 792 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1206      +/-   ##
==========================================
- Coverage   47.86%   47.81%   -0.06%     
==========================================
  Files         369      369              
  Lines       62710    62710              
==========================================
- Hits        30018    29984      -34     
- Misses      30271    30299      +28     
- Partials     2421     2427       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl
Copy link
Member

thehowl commented Oct 28, 2024

Closing as draft for 1yr+.

@thehowl thehowl closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: 🔵 Not Needed for Launch
Development

Successfully merging this pull request may close these issues.

2 participants