Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add links to subdir licenses #1218

Merged
merged 4 commits into from
Nov 24, 2023
Merged

feat: add links to subdir licenses #1218

merged 4 commits into from
Nov 24, 2023

Conversation

waymobetta
Copy link
Contributor

@waymobetta waymobetta commented Oct 10, 2023

Presents the various subdirectory licenses within the main license file (project root).

Closes: 17

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@waymobetta waymobetta added the 📖 documentation Improvements or additions to documentation label Oct 10, 2023
LICENSE.md Outdated Show resolved Hide resolved
LICENSE.md Outdated Show resolved Hide resolved
LICENSE.md Outdated Show resolved Hide resolved
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks good to me as an incremental change we can merge without waiting for Jae, though I think we should reorganise as per #1200 as that solves a couple more things (ie. no ambiguity on examples directory).

@waymobetta
Copy link
Contributor Author

Alright, so which would you prefer: merging this PR now or merging your PR first and then fixing this one after?

@thehowl
Copy link
Member

thehowl commented Nov 24, 2023

Let's merge this one for now, and wait on jae for #1200.

@thehowl thehowl merged commit aaeb808 into gnolang:master Nov 24, 2023
5 checks passed
@waymobetta waymobetta deleted the feat/link-licenses branch November 24, 2023 18:54
gfanton pushed a commit to moul/gno that referenced this pull request Jan 18, 2024
<!-- please provide a detailed description of the changes made in this
pull request. -->

Presents the various subdirectory licenses within the main license file
(project root).

Closes gnolang/devrel#17

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

---------

Co-authored-by: Morgan <git@howl.moe>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation
Projects
Status: 🌟 Wanted for Launch
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants