Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gnolang): allow floats in inc/dec statements #1221

Merged
merged 2 commits into from
Nov 21, 2023
Merged

fix(gnolang): allow floats in inc/dec statements #1221

merged 2 commits into from
Nov 21, 2023

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Oct 10, 2023

Fixes #1151 (split from #1153)

@thehowl thehowl added the 📦 🤖 gnovm Issues or PRs gnovm related label Oct 10, 2023
@thehowl thehowl self-assigned this Oct 10, 2023
@thehowl thehowl requested review from jaekwon, moul and a team as code owners October 10, 2023 23:19
@thehowl thehowl mentioned this pull request Oct 10, 2023
Merged
7 tasks
@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (6688d1d) 55.62% compared to head (15b0ff7) 55.94%.

Files Patch % Lines
gnovm/pkg/gnolang/op_inc_dec.go 0.00% 36 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1221      +/-   ##
==========================================
+ Coverage   55.62%   55.94%   +0.31%     
==========================================
  Files         420      420              
  Lines       65441    65477      +36     
==========================================
+ Hits        36400    36629     +229     
+ Misses      26188    25983     -205     
- Partials     2853     2865      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moul moul requested review from mvertes and piux2 October 11, 2023 15:49
@thehowl thehowl mentioned this pull request Oct 12, 2023
Open
3 tasks
@ajnavarro
Copy link
Contributor

ping @thehowl for merging.

@thehowl
Copy link
Member Author

thehowl commented Oct 20, 2023

@ajnavarro blocked awaiting @piux2 / @jaekwon review.

@moul moul mentioned this pull request Nov 21, 2023
Open
@thehowl
Copy link
Member Author

thehowl commented Nov 21, 2023 •
edited
Loading

Merging per discussion with Ray. (Given Jae has not given feedback yet, we can merge this PR in order to unblock other work.) His concerns regarding the fact that UntypedBigDecType should not be allowed here in the first place can be kept for another PR, by removing the corresponding code also in op_assign.

@thehowl thehowl merged commit 902e678 into master Nov 21, 2023
186 checks passed
@thehowl thehowl deleted the dev/morgan/op-inc-dec-fix branch November 21, 2023 15:54
@michelleellen michelleellen mentioned this pull request Nov 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@ajnavarro ajnavarro ajnavarro approved these changes

@moul moul moul approved these changes

@jaekwon jaekwon Awaiting requested review from jaekwon

@mvertes mvertes Awaiting requested review from mvertes

@piux2 piux2 Awaiting requested review from piux2

Assignees

@thehowl thehowl

Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
🚀 The Launch [DEPRECATED]
Status: 🚀 Needed for Launch
🧐 Review Meeting
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

floats not allowed in inc/dec statements
4 participants
@thehowl @ajnavarro @moul @zivkovicmilos