Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'gno env' subcommand #1233

Merged
merged 28 commits into from
Nov 23, 2023
Merged

feat: add 'gno env' subcommand #1233

merged 28 commits into from
Nov 23, 2023

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Oct 11, 2023

ref: #1217

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (6688d1d) 55.62% compared to head (e76b154) 56.21%.

Files Patch % Lines
tm2/pkg/crypto/keys/client/root.go 0.00% 10 Missing ⚠️
gnovm/pkg/gnoenv/gnoroot.go 79.54% 6 Missing and 3 partials ⚠️
gno.land/cmd/gnokey/main.go 0.00% 5 Missing ⚠️
gnovm/pkg/gnoenv/gnohome.go 90.47% 1 Missing and 1 partial ⚠️
gno.land/pkg/gnoland/app.go 0.00% 1 Missing ⚠️
gnovm/cmd/gno/clean.go 0.00% 1 Missing ⚠️
gnovm/cmd/gno/repl.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1233      +/-   ##
==========================================
+ Coverage   55.62%   56.21%   +0.59%     
==========================================
  Files         420      422       +2     
  Lines       65441    65376      -65     
==========================================
+ Hits        36400    36752     +352     
+ Misses      26188    25759     -429     
- Partials     2853     2865      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gnovm/Makefile Outdated Show resolved Hide resolved
@moul moul changed the title wip: add gnodev feat: add 'gno env' subcommand Oct 11, 2023
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
this is kind of a shortcut as it's really ugly

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
@thehowl thehowl mentioned this pull request Oct 23, 2023
7 tasks
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
@gfanton gfanton marked this pull request as ready for review October 25, 2023 13:45
@gfanton gfanton requested review from a team and jaekwon as code owners October 25, 2023 13:45
@thehowl
Copy link
Member

thehowl commented Oct 26, 2023

realised we duplicated efforts on root dir 🥲 in this pr: #1299

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
@gfanton gfanton merged commit becc4eb into gnolang:master Nov 23, 2023
186 checks passed
@gfanton gfanton deleted the feat/gno-env branch November 23, 2023 17:50
gfanton added a commit to moul/gno that referenced this pull request Jan 18, 2024
thehowl added a commit that referenced this pull request Jan 18, 2024
Related with #1233.

## Before

```
$ gnokeykc --help                                                                                                                                                                                                                                                            
[...]
  -config ...                     config file (optional)                                                                                                                                                                                                                                                 
[...]
```

## After

```
$ gnokeykc --help                                                                                                                                                                                                                                                                 
[...]
  -home /Users/moul/Library/Application Support/gno  home directory                                                                                                                                                                                                                                      
[...]
```

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [x] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

---------

Signed-off-by: moul <94029+moul@users.noreply.github.com>
Co-authored-by: Morgan <git@howl.moe>
Co-authored-by: Hariom Verma <hariom18599@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Status: 🌟 Wanted for Launch
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants