feat: add contribs/gnomd #1256
Merged
feat: add contribs/gnomd #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1256 +/- ##
==========================================
+ Coverage 47.84% 55.89% +8.05%
==========================================
Files 369 421 +52
Lines 62764 66727 +3963
==========================================
+ Hits 30028 37296 +7268
+ Misses 30308 26528 -3780
- Partials 2428 2903 +475 ☔ View full report in Codecov by Sentry. |
This was referenced Oct 20, 2023
thehowl
approved these changes
Nov 2, 2023
Co-authored-by: Morgan <morgan@morganbaz.com>
thehowl
pushed a commit
that referenced
this pull request
Nov 9, 2023
## Done - add a `contribs/gnokeykc` wrapper (adding keychain support). - make `tm2/commands.IO` an interface instead of a struct. ## Usage ```console $ gnokeykc kc set Enter password. Successfully added password for key. $ gnokeykc maketx send --send 1ugnot --to g1fsu3z335h5qngf7t3lmakvpmpwg9ae76tqwh7c --chainid test3 --remote test3.gno.land:36657 --gas-fee "1000000ugnot" --gas-wanted "2000000" --broadcast moul OK! GAS WANTED: 2000000 GAS USED: 47072 ``` ## Links - [x] Depends on #1256 (for contribs/' Makefile & CI) --------- Signed-off-by: moul <94029+moul@users.noreply.github.com>
moul
added a commit
to moul/gno
that referenced
this pull request
Nov 14, 2023
This PR adds a `contribs/gnomd` binary. Please review PR gnolang#1001 for the `maketx run`. Additionally, this PR introduces the `contribs/` folder. It allows the creation of `contribs/gno*` Go packages, Python/Rust/Shell/… scripts. This approach keeps the main `gno`, `gnokey`, and `gnoland` simple while adhering to the Unix philosophy and incorporating several specific gno commands.  --------- Signed-off-by: moul <94029+moul@users.noreply.github.com> Co-authored-by: Morgan <morgan@morganbaz.com>
moul
added a commit
to moul/gno
that referenced
this pull request
Nov 14, 2023
## Done - add a `contribs/gnokeykc` wrapper (adding keychain support). - make `tm2/commands.IO` an interface instead of a struct. ## Usage ```console $ gnokeykc kc set Enter password. Successfully added password for key. $ gnokeykc maketx send --send 1ugnot --to g1fsu3z335h5qngf7t3lmakvpmpwg9ae76tqwh7c --chainid test3 --remote test3.gno.land:36657 --gas-fee "1000000ugnot" --gas-wanted "2000000" --broadcast moul OK! GAS WANTED: 2000000 GAS USED: 47072 ``` ## Links - [x] Depends on gnolang#1256 (for contribs/' Makefile & CI) --------- Signed-off-by: moul <94029+moul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
contribs/gnomdbinary.Please review PR #1001 for the
maketx run.Additionally, this PR introduces the
contribs/folder. It allows the creation ofcontribs/gno*Go packages, Python/Rust/Shell/… scripts. This approach keeps the maingno,gnokey, andgnolandsimple while adhering to the Unix philosophy and incorporating several specific gno commands.