Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add genesis balances subcommand #1276

Merged

Conversation

zivkovicmilos
Copy link
Member

Description

This PR introduces the genesis balances subcommand, as outlined in #1230.

Closes #1230

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@zivkovicmilos zivkovicmilos added the 🌱 feature New update to Gno label Oct 21, 2023
@zivkovicmilos zivkovicmilos self-assigned this Oct 21, 2023
@zivkovicmilos zivkovicmilos requested review from a team, jaekwon and moul as code owners October 21, 2023 17:05
@zivkovicmilos zivkovicmilos marked this pull request as draft October 21, 2023 17:05
@zivkovicmilos zivkovicmilos changed the base branch from master to feat/genesis October 21, 2023 17:06
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Oct 21, 2023
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (505ed60) 47.87% compared to head (b121454) 47.80%.

Additional details and impacted files
@@               Coverage Diff                @@
##           feat/genesis    #1276      +/-   ##
================================================
- Coverage         47.87%   47.80%   -0.07%     
================================================
  Files               369      369              
  Lines             62909    62739     -170     
================================================
- Hits              30120    29995     -125     
+ Misses            30325    30317       -8     
+ Partials           2464     2427      -37     

see 30 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zivkovicmilos zivkovicmilos marked this pull request as ready for review October 21, 2023 19:25
gno.land/cmd/genesis/balances_add.go Outdated Show resolved Hide resolved
gno.land/cmd/genesis/balances_add.go Outdated Show resolved Hide resolved
gno.land/cmd/genesis/balances_add.go Outdated Show resolved Hide resolved
gno.land/cmd/genesis/balances_add.go Show resolved Hide resolved
gno.land/cmd/genesis/utils.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm apart from the "parse all sources" conversation

@zivkovicmilos zivkovicmilos merged commit 7c69d4e into gnolang:feat/genesis Oct 25, 2023
176 checks passed
@zivkovicmilos zivkovicmilos deleted the feat/genesis-balances branch October 25, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 🌱 feature New update to Gno
Projects
Status: 🚀 Needed for Launch
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

[META] [Genesis] genesis balances
3 participants