-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add unused
linter
#1294
Merged
Merged
feat: add unused
linter
#1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📦 🤖 gnovm
Issues or PRs gnovm related
📦 🌐 tendermint v2
Issues or PRs tm2 related
labels
Oct 25, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1294 +/- ##
==========================================
+ Coverage 47.84% 48.02% +0.17%
==========================================
Files 372 371 -1
Lines 62990 62826 -164
==========================================
+ Hits 30140 30170 +30
+ Misses 30384 30197 -187
+ Partials 2466 2459 -7
☔ View full report in Codecov by Sentry. |
thehowl
reviewed
Oct 26, 2023
thehowl
approved these changes
Oct 26, 2023
thehowl
reviewed
Oct 26, 2023
pinging @moul for review/merge |
moul
approved these changes
Nov 8, 2023
moul
pushed a commit
to moul/gno
that referenced
this pull request
Nov 14, 2023
## Description This PR adds the `unused` linter to the linter configuration, and removes unused code segments <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📦 🌐 tendermint v2
Issues or PRs tm2 related
📦 🤖 gnovm
Issues or PRs gnovm related
🌱 feature
New update to Gno
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
unused
linter to the linter configuration, and removes unused code segmentsContributors' checklist...
BREAKING CHANGE: xxx
message was included in the description