Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add unused linter #1294

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Conversation

zivkovicmilos
Copy link
Member

Description

This PR adds the unused linter to the linter configuration, and removes unused code segments

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@zivkovicmilos zivkovicmilos added the 🌱 feature New update to Gno label Oct 25, 2023
@zivkovicmilos zivkovicmilos self-assigned this Oct 25, 2023
@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related labels Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f872ca7) 47.84% compared to head (ab38a21) 48.02%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1294      +/-   ##
==========================================
+ Coverage   47.84%   48.02%   +0.17%     
==========================================
  Files         372      371       -1     
  Lines       62990    62826     -164     
==========================================
+ Hits        30140    30170      +30     
+ Misses      30384    30197     -187     
+ Partials     2466     2459       -7     
Files Coverage Δ
gnovm/pkg/gnolang/helpers.go 22.25% <ø> (+0.25%) ⬆️
gnovm/pkg/gnolang/preprocess.go 31.35% <ø> (+0.17%) ⬆️
gnovm/pkg/gnolang/scanner.go 24.16% <ø> (+1.68%) ⬆️
gnovm/pkg/gnolang/store.go 20.53% <ø> (ø)
gnovm/pkg/gnolang/types.go 16.71% <ø> (ø)
tm2/pkg/amino/binary_decode.go 53.73% <ø> (ø)
tm2/pkg/amino/genproto/bindings.go 82.84% <100.00%> (+2.99%) ⬆️
tm2/pkg/amino/reflect.go 77.01% <ø> (+5.34%) ⬆️
tm2/pkg/bft/consensus/replay.go 66.97% <ø> (ø)
tm2/pkg/bft/consensus/wal_generator.go 80.00% <100.00%> (ø)
... and 13 more

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zivkovicmilos zivkovicmilos marked this pull request as ready for review October 25, 2023 21:51
@zivkovicmilos zivkovicmilos requested review from jaekwon, moul and a team as code owners October 25, 2023 21:51
@thehowl
Copy link
Member

thehowl commented Nov 7, 2023

pinging @moul for review/merge

@moul moul merged commit 31d2ce9 into gnolang:master Nov 8, 2023
182 checks passed
@zivkovicmilos zivkovicmilos deleted the feat/unused-linter branch November 8, 2023 10:56
moul pushed a commit to moul/gno that referenced this pull request Nov 14, 2023
## Description

This PR adds the `unused` linter to the linter configuration, and
removes unused code segments

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 🤖 gnovm Issues or PRs gnovm related 🌱 feature New update to Gno
Projects
Status: Done
Status: 🔵 Not Needed for Launch
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants