Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmd/gno): change set_exit_stauts flag to kebab-case #1304

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix(cmd/gno): change set_exit_stauts flag to kebab-case #1304

merged 1 commit into from
Oct 26, 2023

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Oct 26, 2023

consistency fix

@thehowl thehowl requested a review from a team as a code owner October 26, 2023 17:51
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Oct 26, 2023
gfanton
gfanton approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@codecov
Copy link

codecov bot commented Oct 26, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34d78b3) 47.92% compared to head (8c35f37) 47.31%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1304      +/-   ##
==========================================
- Coverage   47.92%   47.31%   -0.62%     
==========================================
  Files         372      370       -2     
  Lines       62990    61732    -1258     
==========================================
- Hits        30187    29206     -981     
+ Misses      30344    30120     -224     
+ Partials     2459     2406      -53
Files Coverage Δ
gnovm/cmd/gno/lint.go 83.92% <ø> (-0.29%) ⬇️

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl merged commit 7dee385 into master Oct 26, 2023
182 checks passed
@thehowl thehowl deleted the dev/morgan/set-exit-status-snake-fix branch October 26, 2023 18:00
gfanton pushed a commit to gfanton/gno that referenced this pull request Nov 9, 2023
@thehowl @gfanton
fix(cmd/gno): change set_exit_status flag to kebab-case (gnolang#1304)
12c25d1 
consistency fix
moul pushed a commit to moul/gno that referenced this pull request Nov 14, 2023
@thehowl @moul
fix(cmd/gno): change set_exit_status flag to kebab-case (gnolang#1304)
7acf51a 
consistency fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfanton gfanton gfanton approved these changes

Assignees

@thehowl thehowl

Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
🚀 The Launch [DEPRECATED]
Status: No status
🧐 Review Meeting
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thehowl @gfanton