feat(gnolang): add support for octals without 'o' (eg. 0755)
#1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1331 +/- ##
==========================================
+ Coverage 55.98% 56.48% +0.49%
==========================================
Files 420 423 +3
Lines 65443 66738 +1295
==========================================
+ Hits 36640 37698 +1058
- Misses 25940 26142 +202
- Partials 2863 2898 +35 ☔ View full report in Codecov by Sentry. |
thehowl
requested changes
Nov 8, 2023
thehowl
reviewed
Nov 9, 2023
thehowl
changed the title
0755)
✅ Deploy Preview for gno-docs2 canceled.
|
|
@thehowl It seems I'm ready to go. I've changed the previous test to run directly on the |
thehowl
approved these changes
Nov 30, 2023
|
On a second thought, please also make sure to add a couple of test to gnovm/tests/files/, on top of the one you already did. |
I modified them to handle negative expressions (e.g., |
thehowl
reviewed
Dec 7, 2023
moul
reviewed
Dec 10, 2023
moul
approved these changes
Dec 10, 2023
gfanton
pushed a commit
to moul/gno
that referenced
this pull request
Jan 18, 2024
…ng#1331) Updated the condition in `doOpEval` to detect octal literals that start with a '0' followed by octal digits (0-7) related with: gnolang#1322
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the condition in
doOpEvalto detect octal literals that start with a '0' followed by octal digits (0-7)related with: #1322