Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): update tm2 timeout on CI #1337

Merged
merged 1 commit into from
Nov 7, 2023
Merged

chore(ci): update tm2 timeout on CI #1337

merged 1 commit into from
Nov 7, 2023

Conversation

moul
Copy link
Member

@moul moul commented Nov 6, 2023

It should prevent certain flaky tests from failing on GH.
In any case, it increases the high-level timeout to be greater than the timeout for running 'go test'.

Related to issue #1320.

Should prevent some flappy tests.
@moul moul requested a review from a team as a code owner November 6, 2023 13:09
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (789f4de) 47.91% compared to head (130ed79) 47.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1337      +/-   ##
==========================================
- Coverage   47.91%   47.91%   -0.01%     
==========================================
  Files         372      372              
  Lines       63019    63019              
==========================================
- Hits        30194    30193       -1     
- Misses      30363    30364       +1     
  Partials     2462     2462              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice PR number ;)

I don't think necessarily this will fix the issue because I think the root cause for the timeout on _test.pkg.bft is likely to be some kind of deadlock.

In any case, approving & merging -- let's see how it goes.

@thehowl thehowl merged commit 23c5b3b into master Nov 7, 2023
178 of 179 checks passed
@thehowl thehowl deleted the moul-patch-5 branch November 7, 2023 11:00
gfanton pushed a commit to gfanton/gno that referenced this pull request Nov 9, 2023
It should prevent certain flaky tests from failing on GH.
In any case, it increases the high-level timeout to be greater than the
timeout for running 'go test'.

Related to issue gnolang#1320.
moul added a commit to moul/gno that referenced this pull request Nov 14, 2023
It should prevent certain flaky tests from failing on GH.
In any case, it increases the high-level timeout to be greater than the
timeout for running 'go test'.

Related to issue gnolang#1320.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants