style: Increased append readability #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gno-docs2 canceled.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1350 +/- ##
=======================================
Coverage 55.85% 55.85%
=======================================
Files 431 431
Lines 65839 65841 +2
=======================================
+ Hits 36773 36775 +2
Misses 26185 26185
Partials 2881 2881
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zivkovicmilos
approved these changes
Nov 30, 2023
thehowl
approved these changes
Nov 30, 2023
|
Will wait to merge after #1305 because it will introduce conflicts and will be easier to make the changes on this branch. |
3 tasks
gfanton
approved these changes
Dec 21, 2023
|
@deelawn can you merge & resolve conflicts? |
|
There were some issues while merging in master but they should all be fixed now. Anyone want to give this one more look before I merge it? |
thehowl
approved these changes
Jan 15, 2024
gfanton
pushed a commit
to moul/gno
that referenced
this pull request
Jan 18, 2024
I've been looking at append code a lot recently and the current variable naming makes it difficult for me to quickly understand what I'm looking at; these changes help. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been looking at append code a lot recently and the current variable naming makes it difficult for me to quickly understand what I'm looking at; these changes help.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description