-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stdlibs): add package strconv
#1464
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1464 +/- ##
==========================================
- Coverage 56.11% 47.32% -8.80%
==========================================
Files 431 372 -59
Lines 66056 61094 -4962
==========================================
- Hits 37070 28910 -8160
- Misses 26086 29804 +3718
+ Partials 2900 2380 -520
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
So, tests are currently failing. A bunch of tests I've fixed after realising that the underlying problem is with how we do comparisons when we have a bitshift with an untyped integer on the lhs: #1462 (comment) I suspect there may be more bugs involved. In any case, I attempted to make a separate branch from this which merged in the changes from #1426. Turns out, that the tests are completely passing with that code applied to Gno. So, I'll be continuing work on this once #1426 is merged. For the meantime, I'll update the OP to mark what remaining work is to be done to complete this PR so I can easily pick it up later. |
I did this as an experiment, it passes all the test after making a small adjustment on your code,
|
BLOCKED: awaiting merge on #1775, which fixes the underlying bugs causing tests to fail.
This PR adds the full
strconv
package, implemented as pure Gno code. It removes the native functionsItoa
(and others), and adds support for new functions such asFormatFloat
.TODO: