WIP fix: handle assignments to dereferenced pointer values #1501
Conversation
github-actions
bot
added
📦 🤖 gnovm
| @@ -0,0 +1,75 @@ | |||
| # Reproducible Test for https://github.com/gnolang/gno/issues/1167 | |||
There was a problem hiding this comment.
I'm glad you tried txtar-based tests. How was your experience? Do you have any suggestions for improvement? If yes, please refer to #1269.
There was a problem hiding this comment.
This wasn't me, I just copied this: https://gist.github.com/thehowl/e36b0f0d652a2a348a2fcd331a310417. Added a comment there. We should avoid using environment variables for production. Other than that I'm liking it.
There was a problem hiding this comment.
My main thing with tests is this:
I just want "make test" to work as expected, at the root, and at the individual project levels. At the root it should just pass any options and call make test individually.
Anyone who pulls the codebase should be able to get make test passing, and go test ./... should all work as expected too.
There was a problem hiding this comment.
My main thing with tests is this:
I just want "make test" to work as expected, at the root, and at the individual project levels. At the root it should just pass any options and call make test individually.
Anyone who pulls the codebase should be able to get make test passing, and go test ./... should all work as expected too.
That is the case!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1501 +/- ##
==========================================
- Coverage 56.08% 55.75% -0.34%
==========================================
Files 432 431 -1
Lines 66000 66639 +639
==========================================
+ Hits 37016 37153 +137
- Misses 26095 26578 +483
- Partials 2889 2908 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| // unrefCopy makes a copy of the underlying value in the case of reference values. | ||
| // It copies other values as expected using the normal Copy method. | ||
| // XXX DEPRECATED (Copy() now does this). | ||
| // unrefCopy performs a copy but first unrefs if ptr. |
There was a problem hiding this comment.
XXX not true... still need to resolve this...
| // constructed of the correct size. | ||
| // This is more expensive, and should only be called for := | ||
| // define and var decls. | ||
| func (pv PointerValue) Assign3(alloc *Allocator, store Store, rlm *Realm, tv2 TypedValue, cu bool) { |
Alternative fix for #1398
fixes #1326