fix(gnodev): time drifting in gnodev #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
gfanton
force-pushed
the
fix/gnodev-time-drifting
branch
from
f1da45b
to
45a2b5f
Compare
|
I'm putting in the review meeting to quickly assess whether this could have any unintended side effects we might want to guard against. |
zivkovicmilos
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
I'm suspecting this has to do with the moment at which the block proposer starts building the block (creates the VM context for the timestamp). The consensus protocol iterates through rounds until it is able to commit on a block, and move on to the next height. I'm guessing this setting forces the node to begin a new round with a fresh context instead of simply resetting the round (and keeping the old context with the old timestamp).
I'm not so sure this setting is part of the actual consensus (tendermint) specification, or just an in-code optimization (albeit buggy)
thehowl
approved these changes
Jan 12, 2024
gfanton
added a commit
to moul/gno
that referenced
this pull request
Jan 18, 2024
fix gnolang#1507 It appears that using `TestConsensusConfig` as the default consensus configuration in gnodev causes time drift. This can be fixed by setting `cfg.Consensus.SkipTimeoutCommit` to `false`. However, I'm not certain about the exact reason why this setting actually corrects the time drifting issue. Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1507
It appears that using
TestConsensusConfigas the default consensus configuration in gnodev causes time drift. This can be fixed by settingcfg.Consensus.SkipTimeoutCommittofalse. However, I'm not certain about the exact reason why this setting actually corrects the time drifting issue.