Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump the golang-x group with 3 updates #1556

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 18, 2024

Bumps the golang-x group with 3 updates: golang.org/x/crypto, golang.org/x/net and golang.org/x/tools.

Updates golang.org/x/crypto from 0.15.0 to 0.18.0

Commits
  • dbb6ec1 ssh/test: skip tests on darwin that fail on the darwin-amd64-longtest LUCI bu...
  • 403f699 ssh/test: avoid leaking a net.UnixConn in server.TryDialWithAddr
  • 055043d go.mod: update golang.org/x dependencies
  • 08396bb internal/poly1305: drop Go 1.12 compatibility
  • 9d2ee97 ssh: implement strict KEX protocol changes
  • 4e5a261 ssh: close net.Conn on all NewServerConn errors
  • 152cdb1 x509roots/fallback: update bundle
  • fdfe1f8 ssh: defer channel window adjustment
  • b8ffc16 blake2b: drop Go 1.6, Go 1.8 compatibility
  • 7e6fbd8 ssh: wrap errors from client handshake
  • Additional commits viewable in compare view

Updates golang.org/x/net from 0.17.0 to 0.20.0

Commits
  • cb5b10f go.mod: update golang.org/x dependencies
  • 689bbc7 quic: deflake TestStreamsCreateConcurrency
  • f12db26 internal/quic/cmd/interop: use wget --no-verbose in Dockerfile
  • c136d0c quic: avoid panic when PTO expires and implicitly-created streams exist
  • f9726a9 quic: fix packet size logging
  • c337daf quic: enable qlog output in tests
  • 2b416c3 quic/qlog: create log files with O_EXCL
  • 1e59a7e quic/qlog: correctly write negative durations
  • b0eb4d6 quic: compute pnum len from max ack received, not sent
  • b952594 quic: fix data race in connection close
  • Additional commits viewable in compare view

Updates golang.org/x/tools from 0.13.0 to 0.17.0

Release notes

Sourced from golang.org/x/tools's releases.

gopls/v0.14.2

This release contains just one change: an upgrade of x/telemetrygolang/go#63832

Previously, when the telemetry mode was "off" (the default), counter data would not be uploaded, but would be written to the os.UserConfigDir()/go/telemetry/local directory of the local file system. We heard from a few users that, as a matter of policy within their organization, they need a way to prevent even this local data from being written. With this release, running gotelemetry off will stop gopls from writing this local counter data. Note that the os.UserConfigDir()/go/telemetry/mode file must be written to record the "off" state.

The new default telemetry mode is "local", which behaves the same way as "off" did before. In "local" mode, counter data is written to the local file system, but not uploaded. Local data can be inspected with the gotelemetry view command.

See golang/go#63832 for more details. Thanks again for helping us support transparent telemetry in gopls. As described in the v0.14.0 release notes, we are confident that this data will help us produce a better, faster, more reliable product. In fact this is already happening.

gopls/v0.14.1

This release contains just two changes:

  • A workaround for a regression affecting some users of GOPACKAGESDRIVER: golang/go#63751, for example those using gopls with an older version of Bazel. When the go/packages driver is missing compiler or architecture information, gopls now assumes a default value rather than failing to load package information.
  • A fix for a minor bug in the new "remove unused parameter" refactoring: golang/go#63755. Notably, this bug was discovered via an automated report from someone who had opted in to Go telemetry.

gopls/v0.14.0

These are release notes are identical to the v0.14.0-pre.4 prerelease notes. Thanks to all who tested the prerelease!

go install golang.org/x/tools/gopls@v0.14.0

This release includes initial support for the "inline call to function" refactoring, as well as a few other smaller features. It also includes several bug fixes, notably a fix for a performance regression in completion that may be significant in some environments.

The release also contains support for opt-in telemetry. If you want, you can enable the periodic uploading of telemetry data, including gopls stack traces and metrics, but never your source code, to telemetry.go.dev. See below for details.

New Features

Refactoring: inline call to function

This release includes a new code action to inline function calls:

inlinecall

While the outcome of this operation may be a simple replacement, there's a lot going on under the covers. For example, the new inliner checks whether changes to the order of argument evaluation could have unintended consequences. If so, it is careful to replicate the original behavior:

add preserves the order of effects ...but sub does not
inline_add inline_sub

The goal of the inliner is to rewrite your code idiomatically without introducing behavior changes. See the inlining documentation for more details.

When the call cannot be reduced to a simple expression, the inliner may fall back on an immediately invoked function literal (func() { statements }()) as this is often the only way to preserve the original behavior. As we continue to work on refactoring, we'll add additional rewriting strategies that avoid this fall-back in more cases.

Refactoring: removing unused parameters

The techniques described in the previous section serve as a foundation for other refactoring operations. As a proof of concept, this release also includes a code action to remove unused parameters. Since this operation uses inlining behind the scenes, it gets all of the related safety checks and rewriting strategies for free:

inline_unused

... (truncated)

Commits
  • 0b1f1d4 gopls/internal/lsp/cache: (re-)ensure clean shutdown
  • 706525d gopls/internal/lsp/source/completion: support postfix completion (iferr,
  • 581c0b3 gopls/internal/lsp/source: add receiver name to stubbed methods
  • c95fa0f gopls/internal/test: skip marker tests on darwin builders if -short
  • 25a0e9d go.mod: update golang.org/x dependencies
  • c9c95f9 internal/refactor/inline: improve a confusing error message
  • ba8672b go/analysis/passes/unusedresult: add functions from slices package
  • 3e8a0a3 gopls/internal/lsp/cache: address additional comments from CL 553095
  • 920d665 gopls/internal/cmd: factor three loops in fix subcommand
  • 7825736 gopls/internal/lsp/cache: simplify critical errors
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the golang-x group with 3 updates: [golang.org/x/crypto](https://github.com/golang/crypto), [golang.org/x/net](https://github.com/golang/net) and [golang.org/x/tools](https://github.com/golang/tools).


Updates `golang.org/x/crypto` from 0.15.0 to 0.18.0
- [Commits](golang/crypto@v0.15.0...v0.18.0)

Updates `golang.org/x/net` from 0.17.0 to 0.20.0
- [Commits](golang/net@v0.17.0...v0.20.0)

Updates `golang.org/x/tools` from 0.13.0 to 0.17.0
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.13.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang-x
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang-x
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: golang-x
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner January 18, 2024 17:40
@dependabot dependabot bot added the dependencies Update to the dependencies label Jan 18, 2024
@dependabot dependabot bot requested a review from moul January 18, 2024 17:40
@dependabot dependabot bot requested a review from ajnavarro January 18, 2024 17:40
@dependabot dependabot bot requested review from a team and gfanton as code owners January 18, 2024 17:40
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • x/crypto: no significant changes in any crypto algo we use, only significant commits are on x/ssh which we don't use
  • x/net: no changes to netutil, the only thing we use. changes concern mostly quic.
  • x/tools: we only use astutil for the precompile tool. the changes basically only concern having type parameters by default, rather than enabled with a boolean switch

@ajnavarro ajnavarro merged commit 5bca634 into master Jan 22, 2024
2 checks passed
@ajnavarro ajnavarro deleted the dependabot-go_modules-master-golang-x-d4914ede2d branch January 22, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update to the dependencies
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants