-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(misc/autocounterd): init autocounterd #1612
Conversation
7af582a
to
6ac54ae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1612 +/- ##
==========================================
+ Coverage 47.74% 47.79% +0.05%
==========================================
Files 393 393
Lines 61629 61731 +102
==========================================
+ Hits 29424 29505 +81
- Misses 29734 29750 +16
- Partials 2471 2476 +5 ☔ View full report in Codecov by Sentry. |
2fd9f08
to
310f716
Compare
e9d6197
to
27eaf9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit
@thehowl Can this be merge ? |
@albttx We need a second review 🥲 (I pinged the team on monday) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
b8dbdd1
to
cc6184c
Compare
@thehowl @zivkovicmilos All good, all fixed, ps: sorry for --rebase push force 🙈 |
@albttx Otherwise we're good to merge |
@zivkovicmilos good :) |
Co-authored-by: Hariom Verma <hariom18599@gmail.com>
A demo is currently running on the portal loop
you can check https://portal.gnoteam.com/r/portal/counter
close: #1443
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description