Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(make): provide install.gnodev in root makefile #1626

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Feb 2, 2024

cc/ @leohhhn

Since from what I understood we're going to direct users to install gnodev as part of getting started, let's add it as a command in the top level Makefile?

I also took the chance to make everything PHONY.

@thehowl thehowl requested review from moul and leohhhn February 2, 2024 13:44
@thehowl thehowl requested a review from a team as a code owner February 2, 2024 13:44
@thehowl thehowl changed the title chore(make): provide install.gnodev in root makefile chore(make): provide install.gnodev in root makefile Feb 2, 2024
Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@waymobetta
Copy link
Contributor

This makes sense to move to the root. I added a similar comment within the gnodev reference PR since it was unclear.

@leohhhn leohhhn merged commit 95f9fc7 into master Feb 6, 2024
7 of 8 checks passed
@leohhhn leohhhn deleted the dev/morgan/gnodev-in-root-makefile branch February 6, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants