-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add links into navbar #1627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lgtm, @waymobetta do you want this here or on https://github.com/gnolang/docs.gno.land ?
Would be great to see these changes without having to run locally. @albttx, can we set up deployment for PRs in case they handle docs, to have a preview? |
Since the most interesting previews are going to be the visual ones like this one anyway, I suggest you start doing this after migrating to https://github.com/gnolang/docs.gno.land so that config can also be more straightforward. :) |
Thanks @alexiscolin! It seems to me that the "Back to Gno.land" text is of a diferent styling than the other text - can we make it the same for consistency? Also, clicking it opens up a new tab for Gno.land, instead of just using the current one - was this on purpose? |
@alexiscolin can you move you PR to this repo please : https://github.com/gnolang/docs.gno.land @leohhhn Yes i'll work on this once https://github.com/gnolang/docs.gno.land/pull/3/files merged |
@thehowl should we close this ? |
@albttx OK so do we agree this repo will not handle the docs shell anymore but only the content? Because it's not up to date yet and we need to sync on this to be sure all future PR will go there |
This PR aims to add following links into the docs website navbar:
Playground
,blog
andGno.Land homepage
.I chose to avoid setting GnoLand label as
home
in order to avoid a misunderstanding betweendocs home
andGno.Land home
. But we can discuss more about the label and its position here.Close: #1527